Skip to content

metrics: Increase latency minimum range #10718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 8, 2025
Merged

metrics: Increase latency minimum range #10718

merged 1 commit into from
Jan 8, 2025

Conversation

stevenhorsman
Copy link
Member

The bump to kernel 6.12 seems to have reduced the latency in the metrics test, so increase the range for the minimal value, to account for this.

@katacontainersbot katacontainersbot added the size/tiny Smallest and simplest task label Jan 8, 2025
fidencio
fidencio approved these changes Jan 8, 2025
View reviewed changes
Copy link
Member

@fidencio fidencio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @stevenhorsman!

@stevenhorsman stevenhorsman force-pushed the metrics-blogbench-latency-minimal-range-increase branch from c2fb0fa to 3fff1cc Compare January 8, 2025 13:04
@stevenhorsman stevenhorsman changed the title metrics: Increase blogbench write range metrics: Increase latency minimum range Jan 8, 2025
zvonkok
zvonkok approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@zvonkok zvonkok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stevenhorsman
metrics: Increase latency test range
dc069d8 
The bump to kernel 6.12 seems to have reduced the latency in
the metrics test, so increase the ranges for the minimal value,
to account for this.

Signed-off-by: stevenhorsman <steven@uk.ibm.com>
@stevenhorsman stevenhorsman force-pushed the metrics-blogbench-latency-minimal-range-increase branch from 3fff1cc to dc069d8 Compare January 8, 2025 15:11
@fidencio fidencio merged commit 65e2672 into kata-containers:main Jan 8, 2025
290 of 299 checks passed
@stevenhorsman stevenhorsman deleted the metrics-blogbench-latency-minimal-range-increase branch January 9, 2025 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fidencio fidencio fidencio approved these changes

@zvonkok zvonkok zvonkok approved these changes

Assignees
No one assigned
Labels
ok-to-test size/tiny Smallest and simplest task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stevenhorsman @fidencio @zvonkok @katacontainersbot