Skip to content

doc: Update the release process #10668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 19, 2024
Merged

doc: Update the release process #10668

merged 1 commit into from
Dec 19, 2024

Conversation

stevenhorsman
Copy link
Member

Add a step to wait for the payload publish to complete before running the release action.

@stevenhorsman stevenhorsman requested a review from a team as a code owner December 17, 2024 16:09
@katacontainersbot katacontainersbot added the size/tiny Smallest and simplest task label Dec 17, 2024
gkurz
gkurz approved these changes Dec 17, 2024
View reviewed changes
Copy link
Member

@gkurz gkurz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Problem is that successful build isn't required for all assets in CI and people end up merging PRs that break some asset without noticing until we release. I'm fine with adding an extra step as an effort to mitigate the consequences on the release process but we should still straighten the status of assets.

Thanks @stevenhorsman !

sprt
sprt reviewed Dec 17, 2024
View reviewed changes
docs/Release-Process.md
@@ -45,6 +45,14 @@ branch to read only whilst the release action runs.
> [!NOTE]
> Admin permission is needed to complete this task.

### Wait for the `VERSION` bump PR payload publish to complete
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So if the version bump PR fails CI, rerunning it is the way to go?

Copy link
Member Author

@stevenhorsman stevenhorsman Dec 17, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it's either re-run it, or if a fix is required then doing it before the need to mess about with draft releases is easier. Ideally we shouldn't have a broken builds by the time me are doing the version bump anyway - going into a release period with broken nightlies is pretty terrible, but due to issues with the CI caused by other PRs and the christmas crunch meant this is hopefully a one off.

zvonkok
zvonkok approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@zvonkok zvonkok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, lesson learned!

@zvonkok
Copy link
Contributor

zvonkok commented Dec 19, 2024 •
edited
Loading

I still need clarification about Gatekeeper. Shouldn't all build targets be not required, aka not run, if we update the .md?

@katacontainersbot katacontainersbot added size/small Small and simple task and removed size/tiny Smallest and simplest task labels Dec 19, 2024
@stevenhorsman stevenhorsman added the do-not-merge PR has problems or depends on another label Dec 19, 2024
@stevenhorsman
Copy link
Member Author

I still need clarification about Gatekeeper. Shouldn't all build targets be not required, aka not run, if we update the .md?

I've pushed a new commit with an update to the required-test rules to try and address this, just as a point of moving us on a bit. Added do-not-merge whilst this is tested.

@stevenhorsman
Copy link
Member Author

I still need clarification about Gatekeeper. Shouldn't all build targets be not required, aka not run, if we update the .md?

I've pushed a new commit with an update to the required-test rules to try and address this, just as a point of moving us on a bit. Added do-not-merge whilst this is tested.

Damn - in the act of updating the require-tests.yaml this PR is now not a doc only change 😢 - I'll make a temp update to try and get around that for testing.

@stevenhorsman
doc: Update the release process
c3f1326 
Add a step to wait for the payload publish to complete
before running the release action.

Signed-off-by: stevenhorsman <steven@uk.ibm.com>
@stevenhorsman stevenhorsman force-pushed the update-release-process-post-3.12 branch from e5c3905 to 0a3763e Compare December 19, 2024 09:52
@stevenhorsman
Copy link
Member Author

stevenhorsman commented Dec 19, 2024 •
edited
Loading

Damn - in the act of updating the require-tests.yaml this PR is now not a doc only change 😢 - I'll make a temp update to try and get around that for testing.

With my temp commit the gatekeeper job does what I'd expect: https://github.com/kata-containers/kata-containers/actions/runs/12410277581/job/34646671135
(just the WIP and commit message checks fail as we have the do-not-merge label and my temp commit doesn't match the correct format). I will spin this change out as a new PR (#10678), but hopefully once that has merged the gatekeeper will work better for doc only changes.

@stevenhorsman stevenhorsman force-pushed the update-release-process-post-3.12 branch from 0a3763e to c3f1326 Compare December 19, 2024 10:25
@katacontainersbot katacontainersbot added size/tiny Smallest and simplest task and removed size/small Small and simple task labels Dec 19, 2024
@stevenhorsman stevenhorsman mentioned this pull request Dec 19, 2024
Merged
@stevenhorsman stevenhorsman removed the do-not-merge PR has problems or depends on another label Dec 19, 2024
@stevenhorsman stevenhorsman merged commit 7949537 into kata-containers:main Dec 19, 2024
292 of 476 checks passed
@stevenhorsman stevenhorsman deleted the update-release-process-post-3.12 branch December 19, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sprt sprt sprt left review comments

@zvonkok zvonkok zvonkok approved these changes

@gkurz gkurz gkurz approved these changes

Assignees
No one assigned
Labels
ok-to-test size/tiny Smallest and simplest task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@stevenhorsman @zvonkok @sprt @gkurz @katacontainersbot