Skip to content

osbuilder: Fix build dependency of ubuntu rootfs with Docker #10377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 21, 2024
Merged

osbuilder: Fix build dependency of ubuntu rootfs with Docker #10377

merged 1 commit into from
Nov 21, 2024

Conversation

coolljt0725
Copy link
Contributor

When build ubuntu rootfs by using Docker, it failed with the following error:
image

Fix this by adding libclang-dev to the dependency.

@katacontainersbot katacontainersbot added the size/tiny Smallest and simplest task label Oct 3, 2024
@sprt sprt added the ok-to-test label Oct 3, 2024
sprt
sprt reviewed Oct 3, 2024
View reviewed changes
Copy link
Contributor

@sprt sprt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @coolljt0725! Can you fix the failing commit message check and fix it according to our patch format? Your message is missing a body.

https://github.com/kata-containers/kata-containers/actions/runs/11156580172/job/31036786404?pr=10377#step:4:5

https://github.com/kata-containers/community/blob/main/CONTRIBUTING.md#patch-format

@coolljt0725
Copy link
Contributor Author

@sprt updated

fidencio
fidencio approved these changes Oct 8, 2024
View reviewed changes
Copy link
Member

@fidencio fidencio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @coolljt0725!

@ChengyuZhu6
Copy link
Member

@coolljt0725 Please rebase to main to update the workflow.

@coolljt0725
Copy link
Contributor Author

@ChengyuZhu6 rebased

@ChengyuZhu6
Copy link
Member

ChengyuZhu6 commented Oct 15, 2024 •
edited
Loading

image
hi @coolljt0725 . I used the command make rootfs-image-tarball to build rootfs-image with kata main, and it successfully built the agent as well. Could you please provide more detailed steps?

@ChengyuZhu6
Copy link
Member

@sprt @fidencio @amshinde Did you encounter the error mentioned by @coolljt0725 when building rootfs?

@coolljt0725
Copy link
Contributor Author

@ChengyuZhu6 I follow the steps of https://github.com/kata-containers/kata-containers/blob/main/docs/Developer-Guide.md#create-a-rootfs-image

beraldoleal
beraldoleal approved these changes Oct 21, 2024
View reviewed changes
Copy link
Member

@beraldoleal beraldoleal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, LGTM, however 3 required jobs are failing. @wainersm are those safe to ignore?

@sprt
Copy link
Contributor

sprt commented Oct 28, 2024 •
edited
Loading

Rerunning the failed tests.

@Apokleos Apokleos mentioned this pull request Nov 11, 2024
Merged
@zvonkok
Copy link
Contributor

zvonkok commented Nov 20, 2024

@coolljt0725 Can you please rebae? Thanks!

@coolljt0725
osbuilder: Fix build dependency of ubuntu rootfs with Docker
ed4c727 
Build ubuntu rootfs with Docker failed with error:
`Unable to find libclang`

Fix this error by adding libclang-dev to the dependency.

Signed-off-by: Jitang Lei <leijitang@outlook.com>
@coolljt0725
Copy link
Contributor Author

rebased

@stevenhorsman stevenhorsman merged commit b4da4b5 into kata-containers:main Nov 21, 2024
281 of 289 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sprt sprt sprt left review comments

@beraldoleal beraldoleal beraldoleal approved these changes

@fidencio fidencio fidencio approved these changes

@amshinde amshinde amshinde approved these changes

@GabyCT GabyCT GabyCT approved these changes

@stevenhorsman stevenhorsman stevenhorsman approved these changes

Assignees
No one assigned
Labels
ok-to-test size/tiny Smallest and simplest task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@coolljt0725 @ChengyuZhu6 @sprt @zvonkok @beraldoleal @fidencio @amshinde @GabyCT @stevenhorsman @katacontainersbot