Skip to content

packaging: fix the broken usage help #9387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 20, 2024
Merged

packaging: fix the broken usage help #9387

merged 1 commit into from
Dec 20, 2024

Conversation

deagon
Copy link
Contributor

@deagon deagon commented Apr 1, 2024 •
edited
Loading

Fix typos in usage and move the logic of valid check after usage help print.

Fixes: #9386

@katacontainersbot katacontainersbot added the size/small Small and simple task label Apr 1, 2024
beraldoleal
beraldoleal requested changes Apr 2, 2024
View reviewed changes
@beraldoleal beraldoleal self-requested a review April 3, 2024 14:43
beraldoleal
beraldoleal reviewed Apr 3, 2024
View reviewed changes
Copy link
Member

@beraldoleal beraldoleal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a minor comment above, to improve the commit message. But is nit.

@beraldoleal beraldoleal self-requested a review April 3, 2024 14:44
@deagon deagon force-pushed the fix-broken-usage branch from 737afd9 to 010a566 Compare April 8, 2024 05:53
beraldoleal
beraldoleal approved these changes Apr 9, 2024
View reviewed changes
Copy link
Member

@beraldoleal beraldoleal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

@deagon
Copy link
Contributor Author

deagon commented Jun 20, 2024

@justxuewei @Apokleos Take a review please.

@beraldoleal
Copy link
Member

Hi @deagon, sorry for the long hiatus here, our bad. :(

If you are still interested, please rebase and I will merge it if passing all tests.

@deagon
Copy link
Contributor Author

deagon commented Nov 18, 2024

Hi @deagon, sorry for the long hiatus here, our bad. :(

If you are still interested, please rebase and I will merge it if passing all tests.

Sure, sorry for my late.

Using slash will be better for human-reading, maybe.

The new commit would not change other places.

@deagon
Copy link
Contributor Author

deagon commented Nov 18, 2024

@beraldoleal Take a review again, please.

@beraldoleal
Copy link
Member

lgtm, thanks.

@deagon
Copy link
Contributor Author

deagon commented Nov 29, 2024

lgtm, thanks.

@beraldoleal It seams to need a /ok-to-test label for triggers.

@beraldoleal
Copy link
Member

/ok-to-test

justxuewei
justxuewei approved these changes Dec 4, 2024
View reviewed changes
Copy link
Member

@justxuewei justxuewei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thanks! Sorry for the late reply too. I have triggered the tests. Let us get this merged after the tests finish.

@justxuewei
Copy link
Member

Umm, It's so weird. Looks like "WIP Check" doesn't work as expectedly, and can't check its details. Would you mind rebasing onto the master again? @deagon

@deagon deagon force-pushed the fix-broken-usage branch 3 times, most recently from 96846a7 to 3fa96f5 Compare December 18, 2024 12:44
@deagon
packaging: fix the broken usage help
75baf75 
Using the plain usage text instead of the bad variable reference.

Fixes: kata-containers#9386
Signed-off-by: Guoqiang Ding <dgq8211@gmail.com>
@justxuewei
Copy link
Member

Hi @deagon - Please ping me if you encounter any issues. After forced push I can't see any information about the CI issues. Thanks ;)

@deagon
Copy link
Contributor Author

deagon commented Dec 20, 2024

Hi @deagon - Please ping me if you encounter any issues. After forced push I can't see any information about the CI issues. Thanks ;)

@justxuewei Just rebase it to test if passed by the gatekeeper. No more issues.

@justxuewei
Copy link
Member

You can ignore items that are not marked as "Required", e.g. "Gatekeeper" in this case.

@deagon
Copy link
Contributor Author

deagon commented Dec 20, 2024

@justxuewei Got it!

@justxuewei justxuewei merged commit ea60613 into kata-containers:main Dec 20, 2024
288 of 296 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beraldoleal beraldoleal beraldoleal approved these changes

@justxuewei justxuewei justxuewei approved these changes

@GabyCT GabyCT GabyCT approved these changes

Assignees
No one assigned
Labels
ok-to-test size/small Small and simple task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Packaging: broken usage help on the build scripts of guest image
5 participants
@deagon @beraldoleal @justxuewei @GabyCT @katacontainersbot