Skip to content

Conversation

sweepies
Copy link
Contributor

@sweepies sweepies commented Dec 3, 2024

Sometimes when pasting or using a password manager, an extra space is inserted after an email address. I noticed this caused a sign in failure.

Whitespace isn't valid here, so it's safe to just trim this off.

Copy link
Collaborator

@MohamedBassem MohamedBassem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for the PR. This makes sense to me. Left a small comment on the change in the mobile app.

Co-authored-by: Mohamed Bassem <me@mbassem.com>
@sweepies
Copy link
Contributor Author

sweepies commented Dec 9, 2024

Ah right, missed that.

@MohamedBassem MohamedBassem merged commit 16f2ce3 into karakeep-app:main Dec 19, 2024
@MohamedBassem
Copy link
Collaborator

Sorry for the delay. Thanks again for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants