feat(api): enable ?sortOrder= for relevant resources #1398
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
oops, I was trying to rebase the branch and kinda ruined the history :D |
MohamedBassem
approved these changes
May 18, 2025
|
Let me rebase in my fork before we merge! |
8f1939e to
f29d38e
Compare
97423f8 to
b62305a
Compare
|
@MohamedBassem failing tests are now fixed, with some some typing changes, so will need another review over the newly added changes. |
xuatz
commented
May 18, 2025
| @@ -14,7 +12,6 @@ export const GET = (req: NextRequest) => | |||
| searchParamsSchema: z | |||
| .object({ | |||
| q: z.string(), | |||
| sortOrder: zSortOrder.optional().default(zSortOrder.Enum.relevance), | |||
There was a problem hiding this comment.
already present via .and(zGetBookmarkSearchParamsSchema)
xuatz
commented
May 18, 2025
| export const zGetBookmarkSearchParamsSchema = z.object({ | ||
| export const zGetBookmarkQueryParamsSchema = z.object({ |
There was a problem hiding this comment.
zGetBookmarkQueryParamsSchema: not used in /bookmarks/search
zGetBookmarkSearchParamsSchema: used in /bookmarks/search
let me know if you have a better approach for this.
|
Looks good to me, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
sortOrderfunctionality in the api for relevant resourcesNotes
Technically this should be merged after #1392
Btw I'm not sure how much CI magic has been setup and if there are more docs or tasks that I also need to update for this PR, so please let me know if I missed anything.