Hi,

Can I ask why we can't choose the sort order when querying from the API? I can imagine uses for it.

@thiswillbeyourgithub it's an oversight, if you send a PR, I'll happily accept it :)

Thanks for the quick reply. Unfortunately I'm useless at typescript (although Karakeep is a good reason for me to focus more on it!) so I just want to explicitely state that I won't make a PR (i.e. don't wait for me).
If @xuatz doesn't either then I'll create a separate issue to track this feature request.

Thanks for the quick reply. Unfortunately I'm useless at typescript (although Karakeep is a good reason for me to focus more on it!) so I just want to explicitely state that I won't make a PR (i.e. don't wait for me).
If @xuatz doesn't either then I'll create a separate issue to track this feature request.

If it's okay to slightly bloat the PR scope I can include it here!

Thanks for the quick reply. Unfortunately I'm useless at typescript (although Karakeep is a good reason for me to focus more on it!) so I just want to explicitely state that I won't make a PR (i.e. don't wait for me).
If @xuatz doesn't either then I'll create a separate issue to track this feature request.

If it's okay to slightly bloat the PR scope I can include it here!

@thiswillbeyourgithub actually, i change my mind. it involves updating the openapi docs at which I'm not opposed to, but i'm not familiar with. i'll do it in a separate PR.

Hey, that was fast @xuatz!

Overall, the PR looks good to me, however there's a couple of changes I think we need to do:

1. Relevance doesn't make much sense when we're not in a the "search" page, can we hide the relevance option when we're not in the search page?
2. Similarly, I think we should change the getBookmarks endpoint to not accept relevance as one of its sort orders.

@MohamedBassem

for point number 2, I initially went for the approach to make 2 zSortOrders

const zSearchBookmarksSortOrder = z.enum(["asc", "desc", "relevance"]);
const zGetBookmarksSortOrder = z.enum(["asc", "desc"]);

export type ZSortOrder = z.infer<typeof zSearchBookmarksSortOrder>;

But because they both share the same useSortOrderStore(), getBookmarks() is gonna complain that we are potentially giving it relevance.

I guess we can make 2 stores, one specifically for /search and the existing one for the rest, but I got a feeling we probably don't want that.

Instead I've added a cleanup useEffect in SortOrderToggle.tsx, to reset the sort order, if the page is not /search and if the sortOrder is still "relevance"

  // also see related on page enter sortOrder.relevance init
  // in apps/web/app/dashboard/search/page.tsx
  useEffect(() => {
    if (!isDashboardSearchPage && currentSort === "relevance") {
      // reset to default sort order
      setSortOrder("desc");
    }
  }, [isDashboardSearchPage, currentSort]);

Hard to say which approach you prefer, or if you have a 3rd idea, let me know 👍

Thanks a lot @xuatz!