feat: Implement generic rule engine #1318
Conversation
…ing event/action is
Deploying karakeep-landing with
|
| Latest commit: |
df8762e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a75e89cb.karakeep-landing.pages.dev |
| Branch Preview URL: | https://rule-engine.karakeep-landing.pages.dev |
There was a problem hiding this comment.
Pull Request Overview
This PR implements a generic rule engine by adding a new RuleEngineWorker along with its supporting functions and UI components for configuration and management. Key changes include the introduction of the rule engine worker and its integration into existing worker orchestration, updates to several UI components for rule management, and minor UI improvements in other modules.
Reviewed Changes
Copilot reviewed 41 out of 42 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| apps/workers/ruleEngineWorker.ts | New rule engine worker implementation and event processing logic |
| apps/workers/openaiWorker.ts | Integration with the rule engine through new event triggers |
| apps/workers/index.ts | Added RuleEngineWorker to the workers initialization and shutdown process |
| Various components in apps/web/… | Updates to UI elements for rule editor, rule list, and related settings |
Files not reviewed (1)
- apps/web/lib/i18n/locales/en/translation.json: Language not supported
| <CardTitle> | ||
| {rule.id | ||
| ? t("settings.rules.edit_rule") | ||
| : t("settings.rules.ceate_rule")} |
There was a problem hiding this comment.
The localization key 'ceate_rule' appears to be a typo. Consider using 'create_rule' to maintain consistency.
| : t("settings.rules.ceate_rule")} | |
| : t("settings.rules.create_rule")} |
Copilot uses AI. Check for mistakes.
| </span> | ||
| <Button onClick={handleCreateRule} variant="default"> | ||
| <PlusCircle className="mr-2 h-4 w-4" /> | ||
| {t("settings.rules.ceate_rule")} |
There was a problem hiding this comment.
The localization key 'ceate_rule' appears to be a typo. Consider using 'create_rule' to avoid confusion.
| {t("settings.rules.ceate_rule")} | |
| {t("settings.rules.create_rule")} |
Copilot uses AI. Check for mistakes.
Fixes: #1130 #1204