Rename missing files/conf from Hoarder to Karakeep #1280
Conversation
There was a problem hiding this comment.
Wow! Thank you so much for this, I have been procrastinating in doing this for a while now! I also appreciate the thoroughness in the PR description.
- The new mozilla link works now.
- As for pikapods, I'll have to reach out to the folks there first. Let's keep the old link for now.
- Weblate I'll do after merging the PR and I can update the link manually, thanks for pointing it out.
I've left a couple of comments about things that should be reverted, but nothing major. Thanks a lot!
I'm planning to do a release tomorrow or on Monday, let's try to get this PR before that then!
| @@ -1,6 +1,6 @@ | |||
| import { z } from "zod"; | |||
|
|
|||
| export const USER_LOCAL_SETTINGS_COOKIE_NAME = "hoarder-user-local-settings"; | |||
| export const USER_LOCAL_SETTINGS_COOKIE_NAME = "karakeep-user-local-settings"; | |||
There was a problem hiding this comment.
This will break people's local settings (e.g. layouts, etc). I'd keep it as hoarder for now until there's a strong reason to change it.
| Choose _Karakeep_ from their [list of apps](https://www.pikapods.com/apps) or use this [direct link](https://www.pikapods.com/pods?run=karakeep). This will either | ||
| open a new dialog to add a new _Karakeep_ pod or ask you to log in. |
There was a problem hiding this comment.
Pikapod still haven't updated their app's name. Let's revert the link for now.
| - image: ghcr.io/hoarder-app/hoarder-web:${HOARDER_VERSION:-release} | ||
| + image: ghcr.io/hoarder-app/hoarder:${HOARDER_VERSION:-release} | ||
| - image: ghcr.io/hoarder-app/hoarder-web:${KARAKEEP_VERSION:-release} | ||
| + image: ghcr.io/hoarder-app/hoarder:${KARAKEEP_VERSION:-release} |
There was a problem hiding this comment.
It should be ok to update the image link here to karakeep.
packages/sdk/src/index.ts
Outdated
| @@ -1,11 +1,11 @@ | |||
| import createClient from "openapi-fetch"; | |||
|
|
|||
| import type { components, paths } from "./hoarder-api.d.ts"; | |||
| import type { components, paths } from "./karakeep-api.js"; | |||
There was a problem hiding this comment.
shouldn't this be karakeep-api.d.ts instead?
packages/sdk/src/index.ts
Outdated
|
|
||
| /** | ||
| * @deprecated Use createKarakeepClient instead. | ||
| */ | ||
| export const createHoarderClient = createClient<paths>; | ||
| export const createKarakeepClient = createClient<paths>; |
There was a problem hiding this comment.
This should remain as is for backward compatibility. createKarakeepClient is already defined underneath it and this API is already marked as deprecated.
|
Thanks a lot @adripo! |
|
Hi @MohamedBassem sorry for the delay. I was away in the last few days. I see you already solved the pending modifications and merged the PR. Let me know if you need any more help on this. Thanks! |
This PR focuses on renaming the missing parts of the application from Hoarder to Karakeep across the codebase, configurations, and related files. Below is a summary of the changes and notes for review:
Summary of Changes:
File Renaming:
Configuration Updates:
nameinpackage.jsonand if changes in GitHub workflows are necessary or should be reverted.Firefox Add-on Link:
Mobile App Changes:
slug,package, andbundleIdentifierin app.json to reflect the new name if possible.Weblate Migration:
Pikapods Configuration:
Notes for Reviewers: