Skip to content

Conversation

halkeye
Copy link
Contributor

@halkeye halkeye commented Feb 16, 2025

Fix typescript types for #656

I can't say anything about the original implementation, just went with https://stackoverflow.com/questions/46946380/fetch-api-request-timeout and fixed the types

@halkeye halkeye changed the title Halkeye custom fetch wrapper Custom fetch wrapper #656 Feb 16, 2025
@halkeye
Copy link
Contributor Author

halkeye commented Feb 16, 2025

my bad, precommit was spitting so much blank lines i couldn't scroll back, i think processing a compiled file, so i had to skip it.
i can squash the commit when i'm back at a computer.

@MohamedBassem
Copy link
Collaborator

@halkeye don't worry about it, I do squash merging anyways. Thanks a lot for the fix! The PR looks good to me. I'll merge once CI is green!

@MohamedBassem MohamedBassem merged commit 0621cd9 into karakeep-app:main Feb 16, 2025
4 checks passed
@halkeye
Copy link
Contributor Author

halkeye commented Feb 16, 2025

will this generate any sort of nightly docker image or anything I can help test with?

@MohamedBassem
Copy link
Collaborator

@halkeye The nightly image with this commit is being built, and it should be ready in a couple of minutes

@halkeye
Copy link
Contributor Author

halkeye commented Feb 16, 2025

hoarder/hoarder-67977f84bc-qsd8w[app]: Error: Timeout
hoarder/hoarder-67977f84bc-qsd8w[app]:     at Timeout._onTimeout (/app/apps/workers/node_modules/.pnpm/liteque@0.3.2_better-sqlite3@11.3.0/node_modules/liteque/dist/runner.js:2:2775)
hoarder/hoarder-67977f84bc-qsd8w[app]:     at listOnTimeout (node:internal/timers:594:17)
hoarder/hoarder-67977f84bc-qsd8w[app]:     at process.processTimers (node:internal/timers:529:7)

So i'm either getting a different problem, or this doesn't fix it.

Ah well.

Maybe i should just switch and pay openai some money

@MohamedBassem
Copy link
Collaborator

@halkeye This one sounds easy, you need to also increase the timeout of the inference job itself with INFERENCE_JOB_TIMEOUT_SEC. That should stop that particular error from happening.

@halkeye
Copy link
Contributor Author

halkeye commented Feb 16, 2025

sweet sweet success
thx

@halkeye halkeye mentioned this pull request Feb 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants