fix: switch import / export icons #1682
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmmm despite the lucide-icon name, I kinda agree that the image somehow seem to convey the opposite meaning. I agree with the change, but I think we should also make it consistent and apply it across the whole application for other instances (I briefly searched and I think there are only just a handful other instances) |
|
Hey! From the view of a karakeep user, it's IMOH better to switch the icons. It's better than creating confusions ;-)
Both namings makes sense from a different point of view. Best, Michael |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my opinion, the icons for import and export are reversed from what a user would expect them to be.
All this PR does is switch the "Download" and "Upload" symbols in the Import/Export settings menu!
(A world of difference, I know)