feat(admin): add confirmation dialog for user deletion (#1648) #1649
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, LGTM! You don't really need to manage the dialog state in this case, so I've sent this small modification. Thanks for the quick PR and welcome to the contributors list! |
MohamedBassem
approved these changes
Jun 21, 2025
|
@MohamedBassem Thanks a lot! Appreciate the feedback and the tweak 🙌 Excited to contribute more! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances the user deletion UX in the Admin User List by adding a confirmation dialog to prevent accidental deletions
Closes #1648
🧾 Changes Made:
💬Action confirmation dialog (ActionConfirmingDialog) wraps the delete button for each user.
🧠 State: Added local userToDelete state to manage dialog visibility and context.
🎨 Updated translation file:
Added: "delete_user_confirm_description": "Are you sure you want to delete user "{{name}}"?"