Skip to content

chore: update node sku for e2e tests #1341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Aug 1, 2025
Merged

chore: update node sku for e2e tests #1341

merged 10 commits into from
Aug 1, 2025

Conversation

zhuangqh
Copy link
Collaborator

Reason for Change:

Requirements

  • added unit tests and e2e tests (if applicable).

Issue Fixed:

Notes for Reviewers:

@zhuangqh
chore: update node sku for e2e tests
cf704e7 
Signed-off-by: zhuangqh <zhuangqhc@gmail.com>
@zhuangqh zhuangqh requested review from Fei-Guo and chewong as code owners July 31, 2025 03:50
@kaito-pr-agent Kaito PR Agent
Copy link

Title

Update Node SKU for E2E Tests

Description

  • Updated node SKU for e2e tests to Standard_D2_v4

  • Improved cluster creation commands consistency

Changes walkthrough 📝

Relevant files
Enhancement
Makefile
Update node SKU in AKS cluster creation                                   

Makefile

  • Changed node VM size to Standard_D2_v4 in create-aks-cluster target
  • Changed node VM size to Standard_D2_v4 in
    create-aks-cluster-for-karpenter target
    		• +2/-2     
    Need help?
  • Type /help how to ... in the comments thread for any questions about PR-Agent usage.
  • Check out the documentation for more information.
    		•

    @kaito-pr-agent Kaito PR Agent
    Copy link

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Node SKU Change

    The node SKU has been changed from Standard_D2s_v3 to Standard_D2_v4. Ensure that this change aligns with the resource requirements and cost considerations.

     
    --enable-managed-identity --enable-workload-identity --enable-oidc-issuer --node-vm-size Standard_D2_v4 -o none
    Node SKU Change

    The node SKU has been changed from Standard_D2s_v3 to Standard_D2_v4. Ensure that this change aligns with the resource requirements and cost considerations.

     
    --location $(AZURE_LOCATION) --attach-acr $(AZURE_ACR_NAME) --node-vm-size "Standard_D2_v4" \

    @kaito-pr-agent Kaito PR Agent
    Copy link

    PR Code Suggestions ✨

    @zhuangqh
    update
    2d43ad6 
    Signed-off-by: zhuangqh <zhuangqhc@gmail.com>
    @zhuangqh
    fix
    d819725 
    Signed-off-by: zhuangqh <zhuangqhc@gmail.com>
    @zhuangqh
    update
    9ac7dd8 
    Signed-off-by: zhuangqh <zhuangqhc@gmail.com>
    @zhuangqh
    update
    8f286ed 
    Signed-off-by: zhuangqh <zhuangqhc@gmail.com>
    chewong
    chewong reviewed Aug 1, 2025
    View reviewed changes
    @zhuangqh
    update
    97fdd0f 
    Signed-off-by: zhuangqh <zhuangqhc@gmail.com>
    @zhuangqh
    update
    e295151 
    Signed-off-by: zhuangqh <zhuangqhc@gmail.com>
    @zhuangqh
    update
    ca8c6a7 
    Signed-off-by: zhuangqh <zhuangqhc@gmail.com>
    @zhuangqh zhuangqh merged commit ea6216f into kaito-project:main Aug 1, 2025
    11 of 14 checks passed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @chewong chewong chewong left review comments

    @Fei-Guo Fei-Guo Fei-Guo approved these changes

    Assignees
    No one assigned
    Labels
    Review effort 2/5
    Projects
    KAITO Roadmap
    Status: Done
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    4 participants
    @zhuangqh @chewong @Fei-Guo @bangqipropel