Skip to content

feat: adding RAGEngine CRD shortName and ServiceReady status column #1336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 30, 2025
Merged

feat: adding RAGEngine CRD shortName and ServiceReady status column #1336

merged 1 commit into from
Jul 30, 2025

Conversation

bfoley13
Copy link
Collaborator

Reason for Change:
Adding rag as a shortName for RAGEngine CR, and adding a ServiceReady column on the CR to display RAG service readiness.

@kaito-pr-agent Kaito PR Agent
Copy link

Title

Add RAGEngine shortName and ServiceReady status column

Description

  • Added rag as a shortName for RAGEngine CR.

  • Introduced ServiceReady status column in RAGEngine CR.

Changes walkthrough 📝

Relevant files
Enhancement
ragengine_types.go
Update RAGEngine annotations for shortName and ServiceReady

api/v1alpha1/ragengine_types.go

  • Added shortName=rag to RAGEngine resource annotation.
  • Added ServiceReady print column to RAGEngine resource annotation.
    		• +2/-1     
    kaito.sh_ragengines.yaml
    Update CRD for RAGEngine shortName and ServiceReady           

    charts/kaito/ragengine/crds/kaito.sh_ragengines.yaml

  • Added shortNames field with rag value.
  • Added ServiceReady column to additionalPrinterColumns.
    		• +5/-0     
    kaito.sh_ragengines.yaml
    Update CRD for RAGEngine shortName and ServiceReady           

    config/crd/bases/kaito.sh_ragengines.yaml

  • Added shortNames field with rag value.
  • Added ServiceReady column to additionalPrinterColumns.
    		• +5/-0     
    Need help?
  • Type /help how to ... in the comments thread for any questions about PR-Agent usage.
  • Check out the documentation for more information.
    		•

    @kaito-pr-agent Kaito PR Agent
    Copy link

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Possible Issue

    Ensure that the ServiceReady condition is properly set and managed within the RAGEngine controller logic.

     
    // +kubebuilder:printcolumn:name="ServiceReady",type="string",JSONPath=".status.conditions[?(@.type==\"ServiceReady\")].status",description=""
    Consistency Check

    Verify that the ServiceReady column is consistently handled across all CRD definitions and controllers.

     
    - jsonPath: .status.conditions[?(@.type=="ServiceReady")].status
    Consistency Check

    Verify that the ServiceReady column is consistently handled across all CRD definitions and controllers.

     
    - jsonPath: .status.conditions[?(@.type=="ServiceReady")].status

    @kaito-pr-agent Kaito PR Agent
    Copy link

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Impact
    General
    Verify shortName uniqueness

    Ensure that the shortName rag does not conflict with other resources in the cluster.

    api/v1alpha1/ragengine_types.go [102]

    +// +kubebuilder:resource:path=ragengines,scope=Namespaced,categories=ragengine,shortName=rag
 
-
    Suggestion importance[1-10]: 5

    __

    Why: The suggestion asks to verify the uniqueness of the shortName rag, which is a good practice but does not directly modify the code. It is important to ensure there are no conflicts, but this is more of a verification step rather than a code change.

    		Low

    @Fei-Guo Fei-Guo merged commit bfd271a into kaito-project:main Jul 30, 2025
    11 of 12 checks passed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @Fei-Guo Fei-Guo Fei-Guo approved these changes

    @chewong chewong Awaiting requested review from chewong chewong is a code owner

    @zhuangqh zhuangqh Awaiting requested review from zhuangqh zhuangqh is a code owner

    Assignees
    No one assigned
    Labels
    Review effort 2/5
    Projects
    KAITO Roadmap
    Status: Done
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    2 participants
    @bfoley13 @Fei-Guo