Skip to content

fix: image link error in scaler proposals #1318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 28, 2025
Merged

fix: image link error in scaler proposals #1318

merged 1 commit into from
Jul 28, 2025

Conversation

rambohe-ch
Copy link
Collaborator

Reason for Change:

Requirements

  • added unit tests and e2e tests (if applicable).

Issue Fixed:

Notes for Reviewers:

@rambohe-ch
fix image link error in scaler proposals
36648d5 
Signed-off-by: rambohe-ch <rambohe.ch@gmail.com>
@rambohe-ch rambohe-ch requested a review from Fei-Guo as a code owner July 28, 2025 01:45
@kaito-pr-agent Kaito PR Agent
Copy link

Title

Fix image link errors in scaler proposals

Description

  • Corrected image links in scaler proposals

  • Updated paths to static images for consistency

Changes walkthrough 📝

Relevant files
Bug fix
20250611-workspace-subresource-scale-api.md
Update image paths in workspace proposal                                 

website/docs/proposals/20250611-workspace-subresource-scale-api.md

  • Updated image paths to use relative paths
 +4/-4     
20250704-keda-scaler-for-inference-workloads.md
Update image paths in KEDA scaler proposal                             

website/docs/proposals/20250704-keda-scaler-for-inference-workloads.md

  • Updated image paths to use relative paths
 +3/-3     
Need help?
  • Type /help how to ... in the comments thread for any questions about PR-Agent usage.
  • Check out the documentation for more information.
    		•

    @kaito-pr-agent Kaito PR Agent
    Copy link

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Image Path Consistency

    Ensure that all image paths are consistently using either relative or absolute paths. Mixing both styles can lead to broken links depending on how the documentation is served.

     
    ![auto-scaler](../../static/img/workspace-scale-api.png)
    Image Path Consistency

    Ensure that all image paths are consistently using either relative or absolute paths. Mixing both styles can lead to broken links depending on how the documentation is served.

     
    ![keda-kaito-scaler](../../static/img/keda-kaito-scaler.png)
    Typographical Error

    Correct the typo in the sentence "Keda can provides both metric-based and time-based scaler capability". It should be "Keda can provide".

     
    Keda can provides both metric-based and time-based scaler capability, but for metric-based scaler it should work together with prometheus. The detailed auto-scaler architecture is shown in the following figure:

    @kaito-pr-agent Kaito PR Agent
    Copy link

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Impact
    General
    Validate image path

    Verify that the image path is correct and accessible from the documentation build
    environment.

    website/docs/proposals/20250611-workspace-subresource-scale-api.md [52]

    +![auto-scaler](../../static/img/workspace-scale-api.png)
 
-
    Suggestion importance[1-10]: 5

    __

    Why: The suggestion asks to verify the image path, which is a good practice but does not provide a direct improvement to the code. The existing and improved code snippets are identical.

    		Low

    @rambohe-ch rambohe-ch changed the title fix image link error in scaler proposals fix: image link error in scaler proposals Jul 28, 2025
    @Fei-Guo Fei-Guo merged commit 78ef22d into main Jul 28, 2025
    11 of 13 checks passed
    @Fei-Guo Fei-Guo deleted the fix-invalid-image-link branch July 28, 2025 02:04
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @Fei-Guo Fei-Guo Fei-Guo approved these changes

    @chewong chewong Awaiting requested review from chewong chewong is a code owner

    @zhuangqh zhuangqh Awaiting requested review from zhuangqh zhuangqh is a code owner

    Assignees
    No one assigned
    Labels
    Review effort 2/5
    Projects
    KAITO Roadmap
    Status: Done
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    2 participants
    @rambohe-ch @Fei-Guo