-
Notifications
You must be signed in to change notification settings - Fork 121
docs: add aikit to integrations #1303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
TitleAdd AIKit Integration Documentation Description
Changes walkthrough 📝
|
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
This feature is awesome! Let's add a e2e test for it. |
- "run" | ||
- "--address=:5000" | ||
``` | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you add a hint here? users may need to check the memory requirement before they deploy a cpu model and add these requirements to the spec.
OOM is the most common problem we met during deploying a llm model.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, added a note. it is hard to get exact requirements, but i added general guidelines, and a way to get more accurate estimation.
``` | ||
|
||
After building the image, you can use it in your KAITO workspace configuration by updating the `image` field. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also call out the limitations here. What are supported runtimes or anything that works in local AI but not included in this integration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, added a note at the end.
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
@zhuangqh thanks! we can follow up with e2e after docs pr is merged, wdyt? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Reason for Change:
Adds AIKit as part of integrations to extend KAITO with CPU-based inference, and increased custom model support with a variety of different formats.
Requirements
Issue Fixed:
Fixes #1212
Notes for Reviewers:
I'll update versioned docs after LGTM