-
Notifications
You must be signed in to change notification settings - Fork 123
refactor: introduce manifest generator -- part 1 #1284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: jerryzhuang <zhuangqhc@gmail.com>
TitleIntroduce Manifest Generator and Refactor Inference Generation Description
Changes walkthrough 📝
|
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
|
||
type TypedManifestModifier[C GeneratorContext, T ManifestType] func(ctx *C, obj *T) error | ||
|
||
func GenerateManifest[C GeneratorContext, T ManifestType](ctx *C, modifiers ...TypedManifestModifier[C, T]) (*T, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great to see the use of generics 👍🏻
Reason for Change:
Introduce manifest generator to let it easier to be maintained and tested.