-
Notifications
You must be signed in to change notification settings - Fork 122
ci: Expand trivy scanning to other images #1161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
chewong
merged 3 commits into
kaito-project:main
from
robert-cronin:feat/add-scan-for-reference-preset-image
Aug 1, 2025
Merged
ci: Expand trivy scanning to other images #1161
chewong
merged 3 commits into
kaito-project:main
from
robert-cronin:feat/add-scan-for-reference-preset-image
Aug 1, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhuangqh
reviewed
Jun 3, 2025
c4bd823
to
83bb362
Compare
Result from my local run for the preset base os trivy scan:
|
sozercan
reviewed
Jun 3, 2025
sozercan
reviewed
Jun 3, 2025
sozercan
reviewed
Jun 3, 2025
sozercan
reviewed
Jun 3, 2025
sozercan
reviewed
Jun 3, 2025
731f347
to
b728242
Compare
zhuangqh
reviewed
Jun 6, 2025
Signed-off-by: robert-cronin <robert.owen.cronin@gmail.com>
b728242
to
55873eb
Compare
chewong
reviewed
Jul 22, 2025
chewong
reviewed
Jul 24, 2025
12cf976
to
170c0fa
Compare
chewong
reviewed
Jul 28, 2025
Signed-off-by: robert-cronin <robert.owen.cronin@gmail.com>
1d4ef6e
to
4220808
Compare
chewong
approved these changes
Aug 1, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Refactored preset image dockerfile to group os dependencies in one target fo easy scanning
Converted trivy pipeline into matrix strategy
Issue Fixed:
N/A
Notes for Reviewers:
I am not sure if all of these require scanning, happy to cut down to a subset. Some images I've left out because they are quite large, e.g. the
llm-reference-preset
andragservice
images