ci: update workflow perms to job level #570
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
There was a problem hiding this comment.
Pull Request Overview
This PR updates GitHub Actions workflow permissions by moving specific permissions from the workflow level to individual job levels, following security best practices by implementing the principle of least privilege.
- Moves write permissions (
contents,packages,id-token,pull-requests) from workflow level to job level - Sets workflow-level permissions to read-only (
contents: read) - Applies consistent permission structure across all workflow files
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/update-models.yaml | Moves write permissions to job level, sets workflow to read-only |
| .github/workflows/update-models-self.yaml | Moves write permissions to job level, sets workflow to read-only |
| .github/workflows/release.yaml | Moves write permissions to job level, sets workflow to read-only |
| .github/workflows/release-pr.yaml | Moves write permissions to job level, sets workflow to read-only |
| .github/workflows/release-base.yaml | Moves write permissions to job level, sets workflow to read-only |
| .github/workflows/pre-release.yaml | Moves write permissions to job level, sets workflow to read-only |
| .github/workflows/patch-models.yaml | Adds job-level permissions (already had read-only at workflow level) |
| .github/workflows/dependabot.yaml | Moves write permissions to job level, sets workflow to read-only |
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
sozercan
added a commit
that referenced
this pull request
Aug 7, 2025
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when the PR gets merged):Fixes #
Special notes for your reviewer: