fix: return error in LoadMatching
#8234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vishal Choudhary <sendtovishalchoudhary@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #8234 +/- ##
==========================================
+ Coverage 33.85% 33.89% +0.04%
==========================================
Files 260 260
Lines 23570 23570
==========================================
+ Hits 7980 7990 +10
+ Misses 14766 14759 -7
+ Partials 824 821 -3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Good catch, @vishal-chdhry! |
JimBugwadia
previously approved these changes
Sep 4, 2023
|
BTW, it would be nice to have a test for that. This is not something we want to have regressions. |
this loader simulates an invalid loader, such as invalid API call URL or a bad request to external service Signed-off-by: Vishal Choudhary <sendtovishalchoudhary@gmail.com>
74b0bf4
@eddycharly Something like this: |
eddycharly
approved these changes
Sep 4, 2023
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Closes: #8008
I believe this should not return nil, as the value of
errwill be lost.