Skip to content

fix: delete VAPs in case Kyverno policies can't be translated #8887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 27, 2023
Merged

fix: delete VAPs in case Kyverno policies can't be translated #8887

merged 4 commits into from
Nov 27, 2023

Conversation

MariamFahmy98
Copy link
Contributor

@MariamFahmy98 MariamFahmy98 commented Nov 11, 2023 •
edited
Loading

Explanation

This PR ensures the deletion of ValidatingAdmissionPolicies when Kyverno policies are modified and can't be translated to VAPs.

Related issue

Closes #8830

Milestone of this PR

/milestone 1.11.1

What type of PR is this

/kind bug

Proposed Changes

Proof Manifests

Checklist

  • I have read the contributing guidelines.
  • I have read the PR documentation guide and followed the process including adding proof manifests to this PR.
  • This is a bug fix and I have added unit tests that prove my fix is effective.
  • This is a feature and I have added CLI tests that are applicable.
  • My PR needs to be cherry picked to a specific release branch which is .
  • My PR contains new or altered behavior to Kyverno and
    • CLI support should be added and my PR doesn't contain that functionality.
    • I have added or changed the documentation myself in an existing PR and the link is:
    • I have raised an issue in kyverno/website to track the documentation update and the link is:

Further Comments

@MariamFahmy98 MariamFahmy98 added this to the Kyverno Release 1.11.1 milestone Nov 11, 2023
@MariamFahmy98 MariamFahmy98 enabled auto-merge (squash) November 11, 2023 14:18
@codecov Codecov
Copy link

codecov bot commented Nov 11, 2023 •
edited
Loading

Codecov Report

Attention: 28 lines in your changes are missing coverage. Please review.

Comparison is base (1a331f1) 33.60% compared to head (33498bb) 33.58%.

Files Patch % Lines
...s/validatingadmissionpolicy-generate/controller.go 0.00% 28 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8887      +/-   ##
==========================================
- Coverage   33.60%   33.58%   -0.02%     
==========================================
  Files         315      315              
  Lines       24953    24967      +14     
==========================================
  Hits         8386     8386              
- Misses      15769    15783      +14     
  Partials      798      798

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MariamFahmy98 MariamFahmy98 force-pushed the fix-8830 branch 2 times, most recently from 37b27dc to 810113c Compare November 13, 2023 15:48
realshuting
realshuting requested changes Nov 14, 2023
View reviewed changes
@MariamFahmy98
fix: delete VAPs in case Kyverno policies can't be translated
853a6dc 
Signed-off-by: Mariam Fahmy <mariam.fahmy@nirmata.com>
@MariamFahmy98
fix: add an util to construct the vap binding name
2d807c6 
Signed-off-by: Mariam Fahmy <mariam.fahmy@nirmata.com>
@MariamFahmy98 MariamFahmy98 merged commit 1404ea0 into kyverno:main Nov 27, 2023
@realshuting
Copy link
Member

/cherry-pick release-1.11

gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Nov 27, 2023
@MariamFahmy98
fix: delete VAPs in case Kyverno policies can't be translated (#8887)
9c2dd6f 
Signed-off-by: Mariam Fahmy <mariam.fahmy@nirmata.com>
@gcp-cherry-pick-bot gcp-cherry-pick-bot bot mentioned this pull request Nov 27, 2023
Merged
@realshuting realshuting added the cherry-pick-completed The PR was cherry-picked (or merged) to required release branches label Nov 27, 2023
realshuting pushed a commit that referenced this pull request Nov 27, 2023
@gcp-cherry-pick-bot @MariamFahmy98
fix: delete VAPs in case Kyverno policies can't be translated (#8887) (…
3aa662a 
…#9019)

Signed-off-by: Mariam Fahmy <mariam.fahmy@nirmata.com>
Co-authored-by: Mariam Fahmy <mariam.fahmy@nirmata.com>
vishal-chdhry pushed a commit to vishal-chdhry/kyverno that referenced this pull request Jan 5, 2024
@MariamFahmy98 @vishal-chdhry
fix: delete VAPs in case Kyverno policies can't be translated (kyvern…
20c6746 
…o#8887)

Signed-off-by: Mariam Fahmy <mariam.fahmy@nirmata.com>
vishal-chdhry pushed a commit to vishal-chdhry/kyverno that referenced this pull request Jan 5, 2024
@MariamFahmy98 @vishal-chdhry
fix: delete VAPs in case Kyverno policies can't be translated (kyvern…
5dc77a4 
…o#8887)

Signed-off-by: Mariam Fahmy <mariam.fahmy@nirmata.com>
vishal-chdhry pushed a commit to vishal-chdhry/kyverno that referenced this pull request Jan 6, 2024
@MariamFahmy98 @vishal-chdhry
fix: delete VAPs in case Kyverno policies can't be translated (kyvern…
de9e634 
…o#8887)

Signed-off-by: Mariam Fahmy <mariam.fahmy@nirmata.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@realshuting realshuting realshuting approved these changes

@chipzoller chipzoller Awaiting requested review from chipzoller

@eddycharly eddycharly Awaiting requested review from eddycharly eddycharly is a code owner

Assignees

@JimBugwadia JimBugwadia

Labels
cherry-pick-completed The PR was cherry-picked (or merged) to required release branches cherry-pick-required
Projects
None yet
Milestone
Kyverno Release 1.11.1
Development

Successfully merging this pull request may close these issues.

[Bug] The generated VAPs aren't deleted in case Kyverno policy can't be translated
3 participants
@MariamFahmy98 @realshuting @JimBugwadia