Skip to content

Add policyKind option to kyverno-policies chart #8827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 16, 2023
Merged

Add policyKind option to kyverno-policies chart #8827

merged 3 commits into from
Nov 16, 2023

Conversation

treydock
Copy link
Contributor

@treydock treydock commented Nov 3, 2023 •
edited by chipzoller
Loading

Explanation

Related issue

Closes #4317
Closes #8568

Milestone of this PR

/milestone 1.11.1

What type of PR is this

/kind feature

Proposed Changes

Allow the policy "kind" to be changed to Policy which will allow the Kyverno policies chart to deploy namespaced policies.

@treydock
Add policyKind option to kyverno-policies chart
68ad905 
Fixes kyverno#4317 kyverno#8568

Signed-off-by: Trey Dockendorf <tdockendorf@osc.edu>
@treydock treydock requested a review from eddycharly as a code owner November 3, 2023 15:01
@treydock
Copy link
Contributor Author

treydock commented Nov 3, 2023

/cherry-pick release-1.11

@codecov Codecov
Copy link

codecov bot commented Nov 3, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2f5eb56) 33.56% compared to head (f49a6ec) 33.56%.
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #8827   +/-   ##
=======================================
  Coverage   33.56%   33.56%           
=======================================
  Files         315      315           
  Lines       24905    24905           
=======================================
  Hits         8359     8359           
  Misses      15754    15754           
  Partials      792      792

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

MariamFahmy98
MariamFahmy98 reviewed Nov 5, 2023
View reviewed changes
Copy link
Contributor

@MariamFahmy98 MariamFahmy98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In case of Policy, how users set its namespace through the chart values?

@treydock
Copy link
Contributor Author

treydock commented Nov 5, 2023

In case of Policy, how users set its namespace through the chart values?

Can set with --namespace flag in Helm which will set the appropriate namespace for the resources. The docs don't seem to state this but it's mentioned on several Github issues, such as helm/helm#5465 (comment)

@treydock
Copy link
Contributor Author

treydock commented Nov 5, 2023

Typically if you do set namespace the default is like .Release.Namespace which comes from the --namespace flag. I figured best to avoid possible confusion by allowing namespace to be set in 2 different ways that may not match, ie flag and values.yaml.

@rds13 rds13 mentioned this pull request Nov 6, 2023
Merged
9 tasks
@treydock
Copy link
Contributor Author

@realshuting This has hold-merge label, is there still something this PR is waiting on?

@realshuting
Copy link
Member

@realshuting This has hold-merge label, is there still something this PR is waiting on?

No, 1.11.0 is out now. I removed the label, please go ahead with the merge.

@realshuting realshuting merged commit 871d8ed into kyverno:main Nov 16, 2023
gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Nov 16, 2023
@treydock @realshuting
Add policyKind option to kyverno-policies chart (#8827)
1eed562 
Fixes #4317 #8568

Signed-off-by: Trey Dockendorf <tdockendorf@osc.edu>
Co-authored-by: shuting <shuting@nirmata.com>
@gcp-cherry-pick-bot gcp-cherry-pick-bot bot mentioned this pull request Nov 16, 2023
Merged
realshuting added a commit that referenced this pull request Nov 16, 2023
@gcp-cherry-pick-bot @treydock @realshuting
Add policyKind option to kyverno-policies chart (#8827) (#8923)
68e60ff 
Fixes #4317 #8568

Signed-off-by: Trey Dockendorf <tdockendorf@osc.edu>
Co-authored-by: treydock <tdockendorf@osc.edu>
Co-authored-by: shuting <shuting@nirmata.com>
@realshuting realshuting added the cherry-pick-completed The PR was cherry-picked (or merged) to required release branches label Nov 16, 2023
vishal-chdhry pushed a commit to vishal-chdhry/kyverno that referenced this pull request Jan 5, 2024
@treydock @realshuting @vishal-chdhry
Add policyKind option to kyverno-policies chart (kyverno#8827)
52f0e34 
Fixes kyverno#4317 kyverno#8568

Signed-off-by: Trey Dockendorf <tdockendorf@osc.edu>
Co-authored-by: shuting <shuting@nirmata.com>
vishal-chdhry pushed a commit to vishal-chdhry/kyverno that referenced this pull request Jan 5, 2024
@treydock @realshuting @vishal-chdhry
Add policyKind option to kyverno-policies chart (kyverno#8827)
9dc5e20 
Fixes kyverno#4317 kyverno#8568

Signed-off-by: Trey Dockendorf <tdockendorf@osc.edu>
Co-authored-by: shuting <shuting@nirmata.com>
vishal-chdhry pushed a commit to vishal-chdhry/kyverno that referenced this pull request Jan 6, 2024
@treydock @realshuting @vishal-chdhry
Add policyKind option to kyverno-policies chart (kyverno#8827)
06ea4ad 
Fixes kyverno#4317 kyverno#8568

Signed-off-by: Trey Dockendorf <tdockendorf@osc.edu>
Co-authored-by: shuting <shuting@nirmata.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MariamFahmy98 MariamFahmy98 MariamFahmy98 left review comments

@realshuting realshuting realshuting approved these changes

@eddycharly eddycharly Awaiting requested review from eddycharly eddycharly is a code owner

Assignees
No one assigned
Labels
cherry-pick-completed The PR was cherry-picked (or merged) to required release branches cherry-pick-required milestone 1.12.0
Projects
None yet
Milestone
No milestone
3 participants
@treydock @realshuting @MariamFahmy98