Skip to content

Reduced verbosity of admission request filter INFO log message #8712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 10, 2023
Merged

Reduced verbosity of admission request filter INFO log message #8712

merged 5 commits into from
Nov 10, 2023

Conversation

satyazzz123
Copy link
Contributor

@satyazzz123 satyazzz123 commented Oct 21, 2023 •
edited by MariamFahmy98
Loading

Explanation

Reduced verbosity of admission request filter INFO log message which was needlessly flooding kyverno logs

Issue

Closes #8591

Milestone of this PR

What type of PR is this

Proposed Changes

Reduced the logging verbosity by adjusting the log level

Proof Manifests

Checklist

  • I have read the contributing guidelines.
  • I have read the PR documentation guide and followed the process including adding proof manifests to this PR.
  • This is a bug fix and I have added unit tests that prove my fix is effective.
  • This is a feature and I have added CLI tests that are applicable.
  • My PR needs to be cherry picked to a specific release branch which is .
  • My PR contains new or altered behavior to Kyverno and
    • CLI support should be added and my PR doesn't contain that functionality.
    • I have added or changed the documentation myself in an existing PR and the link is:
    • I have raised an issue in kyverno/website to track the documentation update and the link is:

Further Comments

@satyazzz123
Reduced verbosity of admission request filter INFO log message
b4422aa 
Signed-off-by: satyazzz123 <beherasatyajit716@gmail.com>
MariamFahmy98
MariamFahmy98 reviewed Oct 22, 2023
View reviewed changes
@codecov
Copy link

codecov bot commented Oct 22, 2023 •
edited
Loading

Codecov Report

Merging #8712 (5f4ea3a) into main (d898ac9) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main    #8712   +/-   ##
=======================================
  Coverage   33.74%   33.74%           
=======================================
  Files         314      314           
  Lines       24811    24811           
=======================================
  Hits         8373     8373           
  Misses      15643    15643           
  Partials      795      795
Files Coverage Δ
pkg/webhooks/handlers/filter.go 0.00% <0.00%> (ø)

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@satyazzz123
Copy link
Contributor Author

@MariamFahmy98 Do I need to make any changes here??

@rds13 rds13 mentioned this pull request Nov 6, 2023
Merged
9 tasks
@MariamFahmy98
Copy link
Contributor

@MariamFahmy98 Do I need to make any changes here??

Yes. I suggest changing the verbosity level to 4 instead of 1.

MariamFahmy98 and others added 2 commits November 8, 2023 16:29
@MariamFahmy98
Merge branch 'main' into satyazzz123#8591
82c929b
@satyazzz123
Changed the verbosity level to 4
8018ae5 
Signed-off-by: Satyajit Behera <105061492+satyazzz123@users.noreply.github.com>
@satyazzz123
Copy link
Contributor Author

Yes. I suggest changing the verbosity level to 4 instead of 1.

@MariamFahmy98 made the changes. please check

MariamFahmy98
MariamFahmy98 approved these changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@MariamFahmy98 MariamFahmy98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@MariamFahmy98
Copy link
Contributor

@realshuting - which milestone should we get this in?

@satyazzz123
Copy link
Contributor Author

@MariamFahmy98 one test is failing do we i need to address it or we can just merge this PR ?

@MariamFahmy98
Copy link
Contributor

@MariamFahmy98 one test is failing do we i need to address it or we can just merge this PR ?

No need. All tests pass.

@realshuting realshuting enabled auto-merge (squash) November 10, 2023 09:02
@realshuting
Copy link
Member

/cherry-pick release-1.11

@realshuting realshuting merged commit adc0f17 into kyverno:main Nov 10, 2023
@welcome Welcome
Copy link

welcome bot commented Nov 10, 2023

Congratulations! 🎉

Great job merging your first Pull Request here! How awesome! If you are new to this project, feel free to join our Slack community
200w

gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Nov 10, 2023
@satyazzz123 @MariamFahmy98
Reduced verbosity of admission request filter INFO log message (#8712)
3226f3e 
* Reduced verbosity of admission request filter INFO log message

Signed-off-by: satyazzz123 <beherasatyajit716@gmail.com>

* Changed the verbosity level to 4

Signed-off-by: Satyajit Behera <105061492+satyazzz123@users.noreply.github.com>

---------

Signed-off-by: satyazzz123 <beherasatyajit716@gmail.com>
Signed-off-by: Satyajit Behera <105061492+satyazzz123@users.noreply.github.com>
Co-authored-by: Mariam Fahmy <mariam.fahmy@nirmata.com>
@gcp-cherry-pick-bot gcp-cherry-pick-bot bot mentioned this pull request Nov 10, 2023
Merged
@realshuting realshuting added the cherry-pick-completed The PR was cherry-picked (or merged) to required release branches label Nov 13, 2023
realshuting pushed a commit that referenced this pull request Nov 13, 2023
@gcp-cherry-pick-bot @satyazzz123 @MariamFahmy98
Reduced verbosity of admission request filter INFO log message (#8712) (
208ac97 
#8882)

* Reduced verbosity of admission request filter INFO log message



* Changed the verbosity level to 4



---------

Signed-off-by: satyazzz123 <beherasatyajit716@gmail.com>
Signed-off-by: Satyajit Behera <105061492+satyazzz123@users.noreply.github.com>
Co-authored-by: Satyajit Behera <105061492+satyazzz123@users.noreply.github.com>
Co-authored-by: Mariam Fahmy <mariam.fahmy@nirmata.com>
rds13 pushed a commit to Deveryware/kyverno that referenced this pull request Nov 13, 2023
@satyazzz123 @MariamFahmy98 @rds13
Reduced verbosity of admission request filter INFO log message (kyver…
a7aa9c3 
…no#8712)

* Reduced verbosity of admission request filter INFO log message

Signed-off-by: satyazzz123 <beherasatyajit716@gmail.com>

* Changed the verbosity level to 4

Signed-off-by: Satyajit Behera <105061492+satyazzz123@users.noreply.github.com>

---------

Signed-off-by: satyazzz123 <beherasatyajit716@gmail.com>
Signed-off-by: Satyajit Behera <105061492+satyazzz123@users.noreply.github.com>
Co-authored-by: Mariam Fahmy <mariam.fahmy@nirmata.com>
@vishal-chdhry vishal-chdhry mentioned this pull request Nov 23, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcelMue MarcelMue Awaiting requested review from MarcelMue

@realshuting realshuting Awaiting requested review from realshuting realshuting is a code owner

@MariamFahmy98 MariamFahmy98 Awaiting requested review from MariamFahmy98

Assignees

@MariamFahmy98 MariamFahmy98

Labels
cherry-pick-completed The PR was cherry-picked (or merged) to required release branches cherry-pick-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Reduce verbosity of "admission request filter" INFO log message
3 participants
@satyazzz123 @MariamFahmy98 @realshuting