fix: match logic misbehave (cherry-pick #7218) #7237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add rule name in ur for mutate existing Signed-off-by: ShutingZhao <shuting@nirmata.com> * fix match logic Signed-off-by: ShutingZhao <shuting@nirmata.com> * linter fixes Signed-off-by: ShutingZhao <shuting@nirmata.com> * fix the match logic to only apply to the new object, unless it's a delete request Signed-off-by: ShutingZhao <shuting@nirmata.com> * fix unit tests Signed-off-by: ShutingZhao <shuting@nirmata.com> --------- Signed-off-by: ShutingZhao <shuting@nirmata.com>
realshuting
approved these changes
May 18, 2023
Codecov Report
@@ Coverage Diff @@
## release-1.10 #7237 +/- ##
=============================================
Coverage 34.54% 34.55%
=============================================
Files 219 219
Lines 21457 21461 +4
=============================================
+ Hits 7412 7415 +3
- Misses 13322 13324 +2
+ Partials 723 722 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked fix: match logic misbehave (#7218)
Signed-off-by: ShutingZhao shuting@nirmata.com
Signed-off-by: ShutingZhao shuting@nirmata.com
Signed-off-by: ShutingZhao shuting@nirmata.com
Signed-off-by: ShutingZhao shuting@nirmata.com
Signed-off-by: ShutingZhao shuting@nirmata.com
Signed-off-by: ShutingZhao shuting@nirmata.com