fix(chart): only create ServiceMonitor if cluster supports it (cherry-pick #7926) #7931
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: only create ServiceMonitor if cluster supports it Adds an additional check to the ServiceMonitor template to ensure that the cluster supports the `monitoring.coreos.com/v1` API version. Signed-off-by: Alexej Disterhoft <alexej@disterhoft.de> Signed-off-by: Trey Dockendorf <tdockendorf@osc.edu>
6933453 to
81ff4a5
Compare
Codecov Report
@@ Coverage Diff @@
## release-1.10 #7931 +/- ##
=============================================
Coverage 34.61% 34.61%
=============================================
Files 222 222
Lines 21366 21366
=============================================
Hits 7396 7396
Misses 13221 13221
Partials 749 749 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
treydock
approved these changes
Jul 28, 2023
|
New chart will be released via #7933. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked fix(chart): only create ServiceMonitor if cluster supports it (#7926)
Adds an additional check to the ServiceMonitor template to ensure that
the cluster supports the
monitoring.coreos.com/v1API version.Signed-off-by: Alexej Disterhoft alexej@disterhoft.de