Skip to content

Added log message for API call failures (#7834), cherry picked #7880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 21, 2023
Merged

Added log message for API call failures (#7834), cherry picked #7880

merged 2 commits into from
Jul 21, 2023

Conversation

prady0t
Copy link
Contributor

@prady0t prady0t commented Jul 21, 2023 •
edited by realshuting
Loading

Cherry-pick #7834.

  • Added error message to deferred loader on API call failure

  • Small change in error message

Explanation

Related issue

Milestone of this PR

What type of PR is this

Proposed Changes

Proof Manifests

Checklist

  • I have read the contributing guidelines.
  • I have read the PR documentation guide and followed the process including adding proof manifests to this PR.
  • This is a bug fix and I have added unit tests that prove my fix is effective.
  • This is a feature and I have added CLI tests that are applicable.
  • My PR needs to be cherry picked to a specific release branch which is .
  • My PR contains new or altered behavior to Kyverno and
    • CLI support should be added and my PR doesn't contain that functionality.
    • I have added or changed the documentation myself in an existing PR and the link is:
    • I have raised an issue in kyverno/website to track the documentation update and the link is:

Further Comments

@prady0t
Added log message for API call failures (kyverno#7834), cherry picked
03b20ee 
* Added error message to deferred loader on API call failure

Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>

* Small change in error message

Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>

---------

Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>
Co-authored-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>
Co-authored-by: Chip Zoller <chipzoller@gmail.com>
Co-authored-by: shuting <shuting@nirmata.com>
Co-authored-by: Jim Bugwadia <jim@nirmata.com>

Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>
@sonatype-lift
Copy link

sonatype-lift bot commented Jul 21, 2023

Sonatype Lift is retiring

Sonatype Lift will be retiring on Sep 12, 2023, with its analysis stopping on Aug 12, 2023. We understand that this news may come as a disappointment, and Sonatype is committed to helping you transition off it seamlessly. If you’d like to retain your data, please export your issues from the web console.
We are extremely grateful and thank you for your support over the years.

📖 Read about the impacts and timeline

@prady0t prady0t mentioned this pull request Jul 21, 2023
Merged
9 tasks
@realshuting realshuting enabled auto-merge (squash) July 21, 2023 08:03
@codecov
Copy link

codecov bot commented Jul 21, 2023 •
edited
Loading

Codecov Report

Merging #7880 (525172e) into release-1.10 (e18087b) will decrease coverage by 0.01%.
The diff coverage is 50.00%.

@@               Coverage Diff                @@
##           release-1.10    #7880      +/-   ##
================================================
- Coverage         34.68%   34.67%   -0.01%     
================================================
  Files               221      221              
  Lines             21308    21312       +4     
================================================
+ Hits               7390     7391       +1     
- Misses            13177    13179       +2     
- Partials            741      742       +1
Impacted Files Coverage Δ
pkg/engine/context/deferred.go 77.88% <50.00%> (-2.12%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@realshuting realshuting merged commit 4012fab into kyverno:release-1.10 Jul 21, 2023
@prady0t prady0t deleted the release-1.10 branch July 21, 2023 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@realshuting realshuting realshuting approved these changes

@MarcelMue MarcelMue Awaiting requested review from MarcelMue

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@prady0t @realshuting @kyverno-bot