Added fetchAttestations method to notaryV2 implimentation
#6800
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vishal Choudhary <sendtovishalchoudhary@gmail.com>
|
/assign @JimBugwadia |
Codecov Report
@@ Coverage Diff @@
## main #6800 +/- ##
==========================================
- Coverage 33.56% 32.99% -0.58%
==========================================
Files 227 231 +4
Lines 22226 22711 +485
==========================================
+ Hits 7461 7493 +32
- Misses 14039 14477 +438
- Partials 726 741 +15
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: Vishal Choudhary <sendtovishalchoudhary@gmail.com>
Signed-off-by: Vishal Choudhary <sendtovishalchoudhary@gmail.com>
Signed-off-by: Vishal Choudhary <sendtovishalchoudhary@gmail.com>
Signed-off-by: Vishal Choudhary <sendtovishalchoudhary@gmail.com>
fetchAttestations method to notaryV2 implimentationfetchAttestations method to notaryV2 implimentation
Signed-off-by: Vishal Choudhary <sendtovishalchoudhary@gmail.com>
Signed-off-by: Vishal Choudhary <sendtovishalchoudhary@gmail.com>
Signed-off-by: Vishal Choudhary <sendtovishalchoudhary@gmail.com>
Signed-off-by: Vishal Choudhary <sendtovishalchoudhary@gmail.com>
Signed-off-by: Vishal Choudhary <sendtovishalchoudhary@gmail.com>
Signed-off-by: Jim Bugwadia <jim@nirmata.com>
MarcelMue
reviewed
Apr 11, 2023
Signed-off-by: Vishal Choudhary <sendtovishalchoudhary@gmail.com>
Signed-off-by: Vishal Choudhary <sendtovishalchoudhary@gmail.com>
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
…verno#7274) Bumps [github.com/go-git/go-git/v5](https://github.com/go-git/go-git) from 5.6.1 to 5.7.0. - [Release notes](https://github.com/go-git/go-git/releases) - [Commits](go-git/go-git@v5.6.1...v5.7.0) --- updated-dependencies: - dependency-name: github.com/go-git/go-git/v5 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Vishal Choudhary <sendtovishalchoudhary@gmail.com>
|
I see two kuttl failures for the notary tests, can you fix them @vishal-chdhry ? |
|
@realshuting I have updated the image being used to oras discover ghcr.io/kyverno/test-verify-image:signed -o tree
ghcr.io/kyverno/test-verify-image:signed
└── application/vnd.cncf.notary.signature
└── sha256:7f870420d92765b42cec0f71ee8e25bf39b692f64d95d6f6607e9e6e54300265 |
Signed-off-by: Vishal Choudhary <sendtovishalchoudhary@gmail.com>
realshuting
approved these changes
May 25, 2023
realshuting
previously approved these changes
May 25, 2023
Signed-off-by: Vishal Choudhary <sendtovishalchoudhary@gmail.com>
Signed-off-by: Vishal Choudhary <sendtovishalchoudhary@gmail.com>
Signed-off-by: Vishal Choudhary <sendtovishalchoudhary@gmail.com>
Signed-off-by: Vishal Choudhary <sendtovishalchoudhary@gmail.com>
Signed-off-by: Vishal Choudhary <sendtovishalchoudhary@gmail.com>
Signed-off-by: Vishal Choudhary <sendtovishalchoudhary@gmail.com>
realshuting
previously approved these changes
May 31, 2023
JimBugwadia
previously approved these changes
May 31, 2023
| @@ -360,6 +360,7 @@ func decodeStatement(sig oci.Signature) (map[string]interface{}, string, error) | |||
| if err != nil { | |||
| return nil, "", fmt.Errorf("failed to decode statement %s: %w", string(pld), err) | |||
| } | |||
| decodedStatement["type"] = decodedStatement["predicateType"] | |||
There was a problem hiding this comment.
Yes, please check the unit and conformance tests.
|
@vishal-chdhry - can you please resolve conflicts? |
Signed-off-by: Vishal Choudhary <sendtovishalchoudhary@gmail.com>
auto-merge was automatically disabled
June 1, 2023 07:26
Head branch was pushed to by a user without write access
62a0133
Signed-off-by: Vishal Choudhary <sendtovishalchoudhary@gmail.com>
realshuting
approved these changes
Jun 1, 2023
|
Nice work @vishal-chdhry ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Implements a method to fetch attestations, returns digest, and statements of the image
Related issue
Part of #6142
Milestone of this PR
What type of PR is this
Proposed Changes
Proof Manifests
Checklist
Further Comments