Skip to content

Conversation

treydock
Copy link
Contributor

This is a cherry-pick of #3606 to be released with 1.6.

@realshuting If possible it'd be great if once merged a new Helm chart tag was created rather than waiting for next Kyverno 1.6 release.

@treydock treydock requested a review from realshuting April 18, 2022 18:30
@treydock treydock force-pushed the kyvenro-policies-preconditions-1.6 branch from cb53f26 to d4cc177 Compare April 18, 2022 18:30
@chipzoller chipzoller changed the title Kyvenro policies preconditions 1.6 Kyverno policies preconditions 1.6 Apr 18, 2022
@treydock treydock enabled auto-merge (squash) April 20, 2022 00:39
@vyankyGH vyankyGH assigned vyankyGH and realshuting and unassigned vyankyGH Apr 20, 2022
Copy link
Member

@realshuting realshuting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@treydock - can you also bump charts version to v2.3.3 in:

charts/kyverno/Chart.yaml
charts/kyverno-policies/Chart.yaml

I'll create the new tag once merged.

* Allow kyverno-policies to have preconditions defined

Signed-off-by: Trey Dockendorf <tdockendorf@osc.edu>
Signed-off-by: Trey Dockendorf <tdockendorf@osc.edu>
@treydock treydock force-pushed the kyvenro-policies-preconditions-1.6 branch from d4cc177 to 4ba7192 Compare April 20, 2022 21:40
@treydock
Copy link
Contributor Author

@realshuting I bumped chart versions.

@chipzoller
Copy link
Contributor

Can we also take this opportunity to add release notes to README and also add the Artifacthub annotation?

Signed-off-by: Trey Dockendorf <tdockendorf@osc.edu>
@treydock
Copy link
Contributor Author

Can we also take this opportunity to add release notes to README and also add the Artifacthub annotation?

I made some very rough first passes. I also included kyverno chart change that was merged from #3634 to allow defining imagePullSecrets.

Since both these changes exist in main, once the README and annotations are accepted, I can open new pull request for main to get those added to that branch.

@chipzoller
Copy link
Contributor

So do we need to accept another PR first before this?

@chipzoller
Copy link
Contributor

#3645

@treydock
Copy link
Contributor Author

So do we need to accept another PR first before this?

The only other PR the changes mention was merged already, the one about imagePullSecrets.

@treydock treydock merged commit fe8d8cd into kyverno:release-1.6 Apr 21, 2022
@realshuting
Copy link
Member

Helm Chart v2.3.3 is available!

@chipzoller
Copy link
Contributor

And release notes are visible in the README and on Artifacthub.io:

image

@eddycharly
Copy link
Member

Yeah !
We need to polish the format though, we should have a feature/fix/… badge associated to each change.

@chipzoller
Copy link
Contributor

That would also be a nice enhancement to add.

@eddycharly
Copy link
Member

@treydock don't we need to get those changes on main also ?

@treydock
Copy link
Contributor Author

@treydock don't we need to get those changes on main also ?

The Helm chart changes are already in main, what's missing from main is the changes being documented in annotations and README.

@treydock treydock deleted the kyvenro-policies-preconditions-1.6 branch April 21, 2022 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants