-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Kyverno policies preconditions 1.6 #3627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kyverno policies preconditions 1.6 #3627
Conversation
cb53f26
to
d4cc177
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@treydock - can you also bump charts version to v2.3.3
in:
charts/kyverno/Chart.yaml
charts/kyverno-policies/Chart.yaml
I'll create the new tag once merged.
* Allow kyverno-policies to have preconditions defined Signed-off-by: Trey Dockendorf <tdockendorf@osc.edu>
Signed-off-by: Trey Dockendorf <tdockendorf@osc.edu>
d4cc177
to
4ba7192
Compare
@realshuting I bumped chart versions. |
Can we also take this opportunity to add release notes to README and also add the Artifacthub annotation? |
Signed-off-by: Trey Dockendorf <tdockendorf@osc.edu>
I made some very rough first passes. I also included kyverno chart change that was merged from #3634 to allow defining imagePullSecrets. Since both these changes exist in main, once the README and annotations are accepted, I can open new pull request for main to get those added to that branch. |
So do we need to accept another PR first before this? |
The only other PR the changes mention was merged already, the one about imagePullSecrets. |
Helm Chart v2.3.3 is available! |
Yeah ! |
That would also be a nice enhancement to add. |
@treydock don't we need to get those changes on main also ? |
The Helm chart changes are already in main, what's missing from main is the changes being documented in annotations and README. |
This is a cherry-pick of #3606 to be released with 1.6.
@realshuting If possible it'd be great if once merged a new Helm chart tag was created rather than waiting for next Kyverno 1.6 release.