Skip to content

feat(typescript_indexer): support xrefs in nested object literals #6125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 6, 2024
Merged

feat(typescript_indexer): support xrefs in nested object literals #6125

merged 2 commits into from
Aug 6, 2024

Conversation

nbeloglazov
Copy link
Collaborator

Given the following structure:

interface Person {
  name: string;
}

interface Address {
  person: Person;
}

const a: Address = {person: {name: 'Alice'}};

Previously name on the last line was not connected to the Person.name property. This PR fixes it.

@nbeloglazov nbeloglazov enabled auto-merge (squash) August 3, 2024 16:56
@nbeloglazov nbeloglazov merged commit 99d335a into kythe:master Aug 6, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lfolger lfolger lfolger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nbeloglazov @lfolger