feat(java_indexer): add names for native methods #6108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR emits name nodes in the csymbol language for Java native methods according to the JNI spec at https://docs.oracle.com/en/java/javase/11/docs/specs/jni/design.html . Doing this for the JVM indexer is left to future work, mainly thanks to an annoying detail that makes it necessary to know whether a method has multiple native overloads to determine if it will be given a symbol without arguments.
shahms
approved these changes
Apr 22, 2024
| @@ -111,6 +144,61 @@ private static String methodSignature( | |||
| return parentClass.qualifiedName + "." + methodName + methodType; | |||
| } | |||
|
|
|||
| private static String jniMangle(String s) { | |||
There was a problem hiding this comment.
Is this or an equivalent not provided by the JDK?
There was a problem hiding this comment.
Looks like this is implemented in com/sun/tools/javac/jvm/JNIWriter.java, which doesn't expose any sort of external API (the methods are package visible).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR emits name nodes in the csymbol language for Java native methods according to the JNI spec at
https://docs.oracle.com/en/java/javase/11/docs/specs/jni/design.html .
Doing this for the JVM indexer is left to future work, mainly thanks to an annoying detail that makes it necessary to know whether a method has multiple native overloads to determine if it will be given a symbol without arguments.