feat(cxx_indexer): emit symbols for extern C function defns #6104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Symbols for extern "C" function definitions are emitted as name nodes in the symbol language. A function definition node is `named` its name node. The name node uses the corpus of the function it names. (The node kind, language, edge kind, and edge direction are all up for discussion.)
shahms
approved these changes
Apr 18, 2024
jaysachs
reviewed
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Symbols for extern "C" function definitions are emitted as name nodes in the symbol language. A function definition node is
namedits name node. The name node uses the corpus of the function it names. (The node kind, language, edge kind, and edge direction are all up for discussion.)