Skip to content

Conversation

rzhw
Copy link
Contributor

@rzhw rzhw commented Jun 24, 2025

Also adds test coverage for collectCrateSourcesImpl

@varunmahajan
Copy link
Contributor

/gcbrun

@varunmahajan
Copy link
Contributor

/gcbrun

@varunmahajan varunmahajan assigned bmoxb and unassigned sam-mccall Aug 19, 2025
@varunmahajan
Copy link
Contributor

varunmahajan commented Aug 19, 2025

Lint failures.

Trim Trailing Whitespace.................................................Passed
Fix End of Files.........................................................Passed
Check Yaml...........................................(no files to check)Skipped
Check for added large files..............................................Passed
Check for case conflicts.................................................Passed
Check for merge conflicts................................................Passed
Check that executables have shebangs.................(no files to check)Skipped
Check hooks apply to the repository..................(no files to check)Skipped
Check for useless excludes...........................(no files to check)Skipped
Format w/ buildifier.....................................................Failed
- hook id: buildifier
- files were modified by this hook
Check for Kythe Copyright Header.........................................Passed
shellcheck...........................................(no files to check)Skipped
Format w/ google-java-format.........................(no files to check)Skipped
Format w/ clang-format...............................(no files to check)Skipped
Format w/ gofmt..........................................................Passed
golint...................................................................Passed
Build Cleaner............................................................Passed
Regenerate Files.........................................................Passed
All changes made by hooks:
diff --git a/kythe/go/extractors/cmd/rust/BUILD b/kythe/go/extractors/cmd/rust/BUILD
index 25dd1143e..19b1bffd2 100644
--- a/kythe/go/extractors/cmd/rust/BUILD
+++ b/kythe/go/extractors/cmd/rust/BUILD
@@ -33,10 +33,10 @@ go_test(
         "//kythe/proto:analysis_go_proto",
         "//kythe/proto:buildinfo_go_proto",
         "//kythe/proto:storage_go_proto",
+        "@com_github_golang_protobuf//ptypes/any",
         "@com_github_google_go_cmp//cmp",
         "@com_github_google_go_cmp//cmp/cmpopts",
         "@org_golang_google_protobuf//proto",
-        "@com_github_golang_protobuf//ptypes/any",
         "@org_golang_google_protobuf//testing/protocmp",
     ],
 )

@rzhw
Copy link
Contributor Author

rzhw commented Aug 19, 2025

@varunmahajan Sorry! Lint should be fixed now.

@varunmahajan
Copy link
Contributor

/gcbrun

Copy link

@bmoxb bmoxb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@varunmahajan varunmahajan merged commit ad6063b into kythe:master Aug 20, 2025
4 checks passed
@rzhw rzhw deleted the rust_build_config branch August 21, 2025 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants