fix(cxx_extractor): preserve upward relative paths in args #6182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shahms
reviewed
Jun 6, 2025
For projects which use upward relative paths (`../<path>`), the existing PathCleaner logic was insufficient. Particularly, it would output absolute paths for inputs which were specified as ../<path>, which meant that later indexing would fail, as the `arguments` field likely referred to those inputs by their relative paths. We address this with two fixes: 1. PathCleaner now preserves (does not modify) a relative path if it starts with ../ 2. FindStableRoot now outputs the current working directory if any arguments start with ../ Many thanks to @shahms for his advice on this set of changes. Test: Added unit tests Fixes kythe#6181
b54a63a to
8481449
Compare
|
/gcbrun |
varunmahajan
approved these changes
Jun 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For projects which use upward relative paths (
../<path>), the existing PathCleaner logic was insufficient. Particularly, it would output absolute paths for inputs which were specified as ../, which meant that later indexing would fail, as theargumentsfield likely referred to those inputs by their relative paths.We address this with two fixes:
Many thanks to @shahms for his advice on this set of changes.
Test: Added unit tests, also verified manually that this gets the Fuchsia indexing pipeline working again
Fixes #6181