[fix] Correct source_file inclusion in rust extractor #6177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, source file entries were polluted in the cache that speeds up directory traversal. Instead of putting only a single directory's source files in the cache, we were entering the source files for (potentially) the entire crate. Fix: only store source files for the current directory, not the whole crate. Test: proved that Fuchsia's corpus has no more errors like "source_file does not have a required_input entry"
|
/gcbrun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, source file entries were polluted in the cache that speeds up directory traversal. Instead of putting only a single directory's source files in the cache, we were entering the source files for (potentially) the entire crate.
Fix: only store source files for the current directory, not the whole crate.
Test: proved that Fuchsia's corpus has no more errors like "source_file does not have a required_input entry"