Add interface changes in KCD for introducing FetchCUSelector RPC. #6176
Conversation
|
/gcbrun |
kythe/go/platform/kcd/kcd.go
Outdated
| @@ -63,6 +63,11 @@ type Reader interface { | |||
| // the store. | |||
| // If f returns an error, that error is returned from FilesExist. | |||
| FilesExist(_ context.Context, fileDigests []string, f func(string) error) error | |||
|
|
|||
| // FetchCUSelector calls f with the digest of each known compilation matching filter. | |||
There was a problem hiding this comment.
Does this need a new method? Could the existing Find filter be extended to support targets?
There was a problem hiding this comment.
I will get back to this soon.
There was a problem hiding this comment.
FindCUMetadata is a simpler search - supporting only four filters - that too limited to a single corpus, revision, language and providing more data for a CU - specifically solving the use case of an Large Scale Analysis client. (and is more optimized in implementation).
Find is an Advanced Search - providing more filters and supports regex.
The difference lies in the internal implementation of both the APIs and the use case.
Hence, we have kept them as different interface methods.
Also, correponding to each interface method , a filter is used. hence, a new filter.
|
/gcbrun |
|
@aysinha1996 presubmit failed. Can you PTAL? |
Fixed. |
This PR adds the interfaces changes in KCD dbs for introducing FetchCUSelector RPC.