Skip to content

Fix build with Clang 19 #6172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 7, 2025
Merged

Fix build with Clang 19 #6172

merged 2 commits into from
May 7, 2025

Conversation

wittrock
Copy link
Contributor

@wittrock wittrock commented May 1, 2025

See #6171

I wonder if I missed a doc somewhere that should have told me to use an earlier version of clang, but it seems we should be able to build with the latest release of clang available.

So... fix the build with Clang 19.

wittrock added 2 commits May 1, 2025 17:40
@wittrock
souffle: fix build with Clang 19
1e6875b 
Building souffle with Clang 19 results in the error reported in
this issue:
souffle-lang/souffle#2530

That issue is fixed in a pending pull request to souffle:
souffle-lang/souffle@25ef4de
However, that PR has not yet been merged.

For now, unblock the release by adding a patch to our version of souffle
that does the same thing as the PR.
@wittrock
fix: fix rapidjson build with Clang 19
9bb0424 
We ran into the same issue as the rapidjson devs did in 2016:
Tencent/rapidjson#718

The fix is the same:
yachoor/rapidjson@3b2441b

I would have updated rapidjson, but we are actually on the latest release (from 2016!)

Fixes 6171
@varunmahajan varunmahajan self-assigned this May 7, 2025
@varunmahajan
Copy link
Contributor

/gcbrun

@varunmahajan
Copy link
Contributor

Pre-commit (Lint) failed with the error below:

Step #1: INFO: Repository llvm-raw instantiated at:
Step #1: /workspace/WORKSPACE:13:24: in
Step #1: /workspace/setup.bzl:174:10: in kythe_rule_repositories
Step #1: /builder/home/.cache/bazel/_bazel_root/eab0d61a99b6696edb3d2aff87b585e8/external/bazel_tools/tools/build_defs/repo/utils.bzl:240:18: in maybe
Step #1: /workspace/setup.bzl:10:17: in github_archive
Step #1: Repository rule http_archive defined at:
Step #1: /builder/home/.cache/bazel/_bazel_root/eab0d61a99b6696edb3d2aff87b585e8/external/bazel_tools/tools/build_defs/repo/http.bzl:369:31: in
Step #1: ERROR: An error occurred during the fetch of repository 'llvm-raw':
Step #1: Traceback (most recent call last):
Step #1: File "/builder/home/.cache/bazel/_bazel_root/eab0d61a99b6696edb3d2aff87b585e8/external/bazel_tools/tools/build_defs/repo/http.bzl", line 133, column 45, in _http_archive_impl
Step #1: download_info = ctx.download_and_extract(
Step #1: Error in download_and_extract: java.io.IOException: Error extracting /builder/home/.cache/bazel/_bazel_root/eab0d61a99b6696edb3d2aff87b585e8/external/llvm-raw/temp15339922278606035464/cc46d00a86f89b57008ca878e89538d724b7df90.zip to /builder/home/.cache/bazel/_bazel_root/eab0d61a99b6696edb3d2aff87b585e8/external/llvm-raw/temp15339922278606035464: Zip file 'cc46d00a86f89b57008ca878e89538d724b7df90.zip' is malformed. It does not contain an end of central directory record.

@wittrock
Copy link
Contributor Author

wittrock commented May 7, 2025

This looks like a flake, as it's unrelated to my change and may be due to corruption of the http archive for llvm-raw. I also can't reproduce it locally and presubmit passed.

Could you re-run lint?

@wittrock
Copy link
Contributor Author

wittrock commented May 7, 2025

/gcbrun

@wittrock
Copy link
Contributor Author

wittrock commented May 7, 2025

I was hoping I could re-trigger lint. Guess not.

@varunmahajan
Copy link
Contributor

/gcbrun

varunmahajan
varunmahajan approved these changes May 7, 2025
View reviewed changes
Copy link
Contributor

@varunmahajan varunmahajan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@varunmahajan varunmahajan merged commit 656254b into kythe:master May 7, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@varunmahajan varunmahajan varunmahajan approved these changes

Assignees

@varunmahajan varunmahajan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wittrock @varunmahajan