FYI @meteorcloudy

/cc @coeuvre With this, maybe we could inject Kythe more elegantly on Bazel CI: https://github.com/bazelbuild/continuous-integration/blob/fe56acdc33166e14a73ee5efd082480768c6e268/buildkite/bazelci.py#L2072

@meteorcloudy @coeuvre @sam-mccall @varunmahajan it would be nice to get this merged so that we can start using this in BzlMod repos

/gcbrun

Lint check failed

Step #1: Trim Trailing Whitespace.................................................Passed
Step #1: Fix End of Files.........................................................Passed
Step #1: Check Yaml...........................................(no files to check)Skipped
Step #1: Check for added large files..............................................Passed
Step #1: Check for case conflicts.................................................Passed
Step #1: Check for merge conflicts................................................Passed
Step #1: Check that executables have shebangs.....................................Passed
Step #1: Check hooks apply to the repository..................(no files to check)Skipped
Step #1: Check for useless excludes...........................(no files to check)Skipped
Step #1: Format w/ buildifier.....................................................Passed
Step #1: Check for Kythe Copyright Header.........................................Failed
Step #1: - hook id: copyright
Step #1: - exit code: 1
Step #1:
Step #1: kythe/release/release.MODULE.bazel
Step #1:
Step #1: shellcheck...............................................................Passed
Step #1: Format w/ google-java-format.........................(no files to check)Skipped
Step #1: Format w/ clang-format...............................(no files to check)Skipped
Step #1: Format w/ gofmt......................................(no files to check)Skipped
Step #1: golint...............................................(no files to check)Skipped
Step #1: Build Cleaner............................................................Passed
Step #1: Regenerate Files.........................................................Passed

Presubmit check failed

Step #3 - "bazel-release": ERROR: /workspace/kythe/release/BUILD:27:8: in cmd attribute of genrule rule //kythe/release:release: label '//kythe/release:release.MODULE.bazel' in $(location) expression is not a declared prerequisite of this rule
Step #3 - "bazel-release": ERROR: /workspace/kythe/release/BUILD:27:8: Analysis of target '//kythe/release:release' failed
Step #3 - "bazel-release": Analyzing: 2585 targets (1012 packages loaded, 39527 targets configured)
Step #3 - "bazel-release": [10,771 / 22,833] 31 / 360 tests; checking cached actions
Step #3 - "bazel-release": Use --verbose_failures to see the command lines of failed build steps.
Step #3 - "bazel-release": ERROR: Analysis of target '//kythe/release:release_test' failed; build aborted: Analysis failed
Step #3 - "bazel-release": INFO: Elapsed time: 32.707s, Critical Path: 5.08s
Step #3 - "bazel-release": INFO: 7335 processes: 3963 remote cache hit, 3368 internal, 2 linux-sandbox, 2 local.
Step #3 - "bazel-release": ERROR: Build did NOT complete successfully

I updated the lint config and added the missing dependency, PTAL.

/gcbrun

Lint check fails with the same error:

Step #1: Check for Kythe Copyright Header.........................................Failed
Step #1: - hook id: copyright
Step #1: - exit code: 1
Step #1:
Step #1: kythe/release/release.MODULE.bazel

@fmeum iiuc, it's running the pre-commit hooks and failed. So just update the exclusions here https://github.com/kythe/kythe/blob/9e3a840bf15781e641455e497c7da62de642f6c3/.pre-commit-config.yaml#L34C9-L42 and you should be gucci

@fmeum iiuc, it's running the pre-commit hooks and failed. So just update the exclusions here https://github.com/kythe/kythe/blob/9e3a840bf15781e641455e497c7da62de642f6c3/.pre-commit-config.yaml#L34C9-L42 and you should be gucci

I thought I had done that, but I didn't match the right file. Should be fixed now. I am seeing a number of violations when I run pre-commit run --all locally, but I think that's due to using a more recent version of buildifier.

/gcbrun

/gcbrun