fix(bazel): remove cyclic dependency by removing usage of assign_external_projects_to_separate_corpora config_setting flag #6146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rnal_projects_to_separate_corpora config_setting flag
amitcodescpp
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usage of
assign_external_projects_to_separate_corporaalong withselectstatement is causing a cyclic dependency for Bazel 8. Also not usage of flagassign_external_projects_to_separate_corporawas found hence deprecating the flag. The flag was initially introduced for backward compatibility in https://source.corp.google.com/h/github/kythe/kythe/+/3966e3f7aa790a61645e6babf511f7ae21b78011.Tested by executing bazelisk --bazelrc=$KYTHE_RELEASE_DIR/extractors.bazelrc build //src:bazel which succeeded.