Skip to content

feat(go_indexer): support vars denoting flags #6037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 26, 2024
Merged

feat(go_indexer): support vars denoting flags #6037

merged 4 commits into from
Feb 26, 2024

Conversation

schroederc
Copy link
Contributor

No description provided.

@schroederc schroederc requested a review from a team February 26, 2024 19:27
@schroederc schroederc enabled auto-merge (squash) February 26, 2024 19:27
@shahms
Copy link
Contributor

shahms commented Feb 26, 2024 

ERROR: Traceback (most recent call last):
	File "/workspace/kythe/go/indexer/BUILD", line 411, column 21, in <toplevel>
		flag_constructor(
	File "/workspace/kythe/go/indexer/flags.bzl", line 15, column 29, in flag_constructor
		return proto.encode_text(struct(
Error in encode_text: in struct field .var_arg_position: got NoneType, want string, int, bool, or struct
ERROR: package contains errors: kythe/go/indexer
ERROR: package contains errors: kythe/go/indexer: Traceback (most recent call last):
	File "/workspace/kythe/go/indexer/BUILD", line 411, column 21, in <toplevel>
		flag_constructor(
	File "/workspace/kythe/go/indexer/flags.bzl", line 15, column 29, in flag_constructor
		return proto.encode_text(struct(
Error in encode_text: in struct field .var_arg_position: got NoneType, want string, int, bool, or struct
ERROR: Error evaluating '//...': error loading package 'kythe/go/indexer': Package 'kythe/go/indexer' contains errors

@schroederc
Copy link
Contributor Author

Seems like behavior differs between Bazel 6 and 7 on this.

shahms
shahms reviewed Feb 26, 2024
View reviewed changes
@schroederc schroederc disabled auto-merge February 26, 2024 20:20
@schroederc schroederc enabled auto-merge (squash) February 26, 2024 20:53
@schroederc schroederc merged commit 02543b1 into kythe:master Feb 26, 2024
@schroederc schroederc deleted the go-var-flags branch February 26, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@shahms shahms shahms approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@schroederc @shahms