fix(cxx_indexer): use flat_hash_map, not unordered_map; fix rehashing #6083
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also remove a bizarre constructor from NodeId.
shahms
reviewed
Mar 23, 2024
| } | ||
| // Note that `iter` may be invalidated if a recursive call causes TypeNodes to | ||
| // rehash. We'll still insert an empty set out of superstition about recursive | ||
| // types. |
There was a problem hiding this comment.
Just use find() + insert() like BuildNodeIdForDecl does for the same reasons?
There was a problem hiding this comment.
I'd be very surprised if there were a cycle in decls (there is a self-loop in BuildNodeIdForDecl), less so if somehow there's one in types.
shahms
approved these changes
Mar 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also remove a bizarre constructor from NodeId.