feat(testing): provide ability to save logs from indexers in verifier_test #6075
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
@shahms PTAL |
shahms
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances
verifier_testin a few ways.Adds
KytheEntries.logandKytheEntries.namefields.KytheEntriesis a provider created by bazel actions that execute indexers. The newlogfield contains path of a log file from the indexer execution. It allows to propagate log files to theverifier_testwhich later saves them in output directory.Adds
KytheEntryProducerInfo.namefield.KytheEntryProducerInfois a provider that contains shell script that executes indexers.verifier_testlater runs these scripts as part of tests. With this new change logs from these scripts are stored in separate files (one per indexer execution) in test output folder.This change is a required to improve developer experience who write Kythe integration tests that involve multiple indexers. It's mostly targeting Google infra where files stored in TEST_UNDECLARED_OUTPUTS_DIR are displayed in test result UI. For bazel users it might be a regression because bazel simply collects all files from TEST_UNDECLARED_OUTPUTS_DIR in a zip file that developer later has to inspect manually.