Skip to content

Conversation

justbuchanan
Copy link
Contributor

I copied this entry from vnames.json.

Before this change, extracting the kythe repo using the bazel-extractor image results in this entry in required_inputs for protos that depend on descriptor.proto:

      "v_name": {
        "corpus": "CORPUS",
        "root": "bazel-out/bin/external/com_google_protobuf",
        "path": "src/google/protobuf/_virtual_imports/descriptor_proto/google/protobuf/descriptor.proto"
      },

After this change, we get:

      "v_name": {
        "corpus": "CORPUS",
        "root": "bazel-out/bin",
        "path": "google/protobuf/descriptor.proto"
      },

This extraction change should fix errors we've been seeing where the indexer is unable to find descriptor.proto (or other external protos) and fails.

@justbuchanan justbuchanan requested a review from a team March 19, 2024 18:45
@justbuchanan justbuchanan merged commit 452cf71 into master Mar 19, 2024
@justbuchanan justbuchanan deleted the fixproto branch March 19, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants