fix(cxx_extractor): allow empty PathEntry flag values #6050
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shahms
reviewed
Mar 12, 2024
shahms
approved these changes
Mar 12, 2024
|
Thank you for fixing this! I've been poking at using kythe for some projects I work on and I was regularly hitting this and didn't understand why. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this change, leaving the
--per_file_canonicalization_policyflag unset results in[external/com_google_absl/absl/flags/internal/flag.cc : 598] RAW: Flag per_file_canonicalization_policy (from kythe/cxx/extractor/cxx_extractor_bazel_main.cc): string form of default value '' could not be parsed; error=missing @ delimiter between path and policy