Skip to content

fix(bazel): alternate method of installing bazelisk in docker image #6041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 6, 2024
Merged

fix(bazel): alternate method of installing bazelisk in docker image #6041

merged 1 commit into from
Mar 6, 2024

Conversation

justbuchanan
Copy link
Contributor

Before this change, attempts to build the bazel extractor image fail with:

bazel build //kythe/extractors/bazel:docker

ERROR: error loading package '@@com_github_bazelbuild_bazelisk//': Unable to find package for @@build_bazel_rules_nodejs//:index.bzl: The repository '@@build_bazel_rules_nodejs' could not be resolved: Repository '@@build_bazel_rules_nodejs' is not defined.
ERROR: /usr/local/google/home/justinbuchanan/src/github/kythe/kythe/extractors/bazel/BUILD:3:13: error loading package '@@com_github_bazelbuild_bazelisk//': Unable to find package for @@build_bazel_rules_nodejs//:index.bzl: The repository '@@build_bazel_rules_nodejs' could not be resolved: Repository '@@build_bazel_rules_nodejs' is not defined. and referenced by '//kythe/extractors/bazel:docker'
ERROR: Analysis of target '//kythe/extractors/bazel:docker' failed; build aborted: Analysis failed
INFO: Elapsed time: 0.330s, Critical Path: 0.00s
INFO: 1 process: 1 internal.
ERROR: Build did NOT complete successfully

I copied the bazelisk download/install snippet from our presubmit-runner image.

@justbuchanan justbuchanan requested a review from a team March 6, 2024 21:50
@justbuchanan justbuchanan merged commit af62dce into kythe:master Mar 6, 2024
@justbuchanan justbuchanan deleted the fix-bazel-image branch March 6, 2024 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@shahms shahms shahms approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@justbuchanan @shahms