Skip to content

fix(verifier): various fixes for new solver #5830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 5, 2023
Merged

fix(verifier): various fixes for new solver #5830

merged 1 commit into from
Sep 5, 2023

Conversation

zrlk
Copy link
Contributor

@zrlk zrlk commented Sep 5, 2023

  • improve some diagnostics (evar numbers instead of nil)
  • don't run inspections on empty output
  • make range expressions work under equalities
  • pass in a proper root in a test (the old solver by default didn't care)
  • document the need to deal with evar type equality

@zrlk
fix(verifier): various fixes for new solver
cd6c2de 
  * improve some diagnostics (evar numbers instead of <nil>)
  * don't run inspections on empty output
  * make range expressions work under equalities
  * pass in a proper root in a test (the old solver by default didn't care)
  * document the need to deal with evar type equality
@zrlk zrlk enabled auto-merge (squash) September 5, 2023 19:28
@zrlk zrlk requested a review from a team September 5, 2023 19:29
@zrlk zrlk merged commit a40be3e into kythe:master Sep 5, 2023
@zrlk zrlk deleted the mvt branch September 5, 2023 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@shahms shahms shahms approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zrlk @shahms