Skip to content

Fix ui start command #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix ui start command #1

wants to merge 1 commit into from

Conversation

tsl0922
Copy link
Contributor

@tsl0922 tsl0922 commented Jan 29, 2015 

vagrant@jessie64:/vagrant$ ./campfire run //kythe/go/serving/xrefs/tools:xrefs_server --port 8080 --graphstore .kythe_graphstore
ninja: no work to do.
flag provided but not defined: -port
Usage of /vagrant/campfire-out/bin/kythe/go/serving/xrefs/tools/xrefs_server:
  -graphstore=<nil>: GraphStore to which to write the entry stream
  -indirect_names=false: For xrefs calls, indirect through name nodes to get a complete set of references
  -listen="localhost:8080": HTTP serving address
  -serving_path="kythe/web/ui/resources/public": Path to public serving directory
  -skip_preprocessing=false: Skip GraphStore preprocessing
  -tables="": Path to xrefs tables to serve

@tsl0922
Copy link
Contributor Author

tsl0922 commented Jan 29, 2015

Also, it seems the --graphstore does not work for dir in the vagrant share folder. It will work if I change the .kythe_graphstore to somewhere outside the /vagrant, eg: /tmp/graphstore.

This is the error message I got:

vagrant@jessie64:/vagrant$ docker run --rm \
>   -v "${PWD}:/repo" \
>   -v "${PWD}/.kythe_compilations:/compilations" \
>   -v "${PWD}/.kythe_graphstore:/graphstore" \
>   google/kythe --index
Skipping extraction
invalid value "/graphstore" for flag -graphstore: error opening LevelDB GraphStore: could not open LevelDB at "/graphstore": IO error: /graphstore: Invalid argument
write_entries - writes the entries from a delimited stream on stdin to a GraphStore
usage: write_entries [--batch_size entries] [--workers n] --graphstore spec
  -batch_size=1024: Maximum entries per write for consecutive entries with the same source
  -cpu_profile="": Write CPU profile to the specified file (if nonempty)
  -graphstore=<nil>: GraphStore to which to write the entry stream
  -workers=1: Number of concurrent workers writing to the GraphStore
Indexing /compilations/java/kythe_javatests_com_google_devtools_kythe_analyzers_java_testdata_pkg_selectors_lib.java.kindex
2015/01/29 15:04:10 write /dev/stdout: broken pipe
141 analysis failures

@schroederc
Copy link
Contributor

Thanks for the comments! For making changes to Kythe, we require a Contributor License Agreement and code review (see http://www.kythe.io/contributing#code-review) so we can't just accept this pull request. However, if you want, I can add this to a few other documentation fixes I have and submit it myself.

As for Vagrant, we haven't tested our tools in that environment yet and would appreciate any further changes you want to put forward.

@tsl0922
Copy link
Contributor Author

tsl0922 commented Jan 30, 2015

Hi, @schroederc

I've sent the patch at http://www.kythe.io/phabricator, and signed the CLA at https://cla.developers.google.com/about, please check.

Another question: is there any plan to support Mac OS X? I'm running kythe with vagrant on VirtualBox currently.

Mac OS X is case insensitive by default, CAMPFIRE and campfire in the repo root will be an issue.

@schroederc
Copy link
Contributor

Thanks!

We definitely want to support Mac OS X. It's on our list: http://kythe.io/phabricator/T3.

@schroederc schroederc closed this Jan 30, 2015
zrlk added a commit that referenced this pull request Apr 21, 2017
@zrlk
Support % and # prefixes for fact names and edge kinds
d7c2e08 
Summary:
Addresses T243.

The ambiguity between @foo#1 and #edge is addressed by dropping the HASH
token and replacing it with HASH_NUMBER, which is a # followed by
whitespace followed by an integer.

Reviewers: schroederc, #core_team, shahms

Reviewed By: #core_team, shahms

Subscribers: #core_team

Differential Revision: https://phabricator-dot-kythe-repo.appspot.com/D1564
This was referenced Jun 25, 2018
Closed
Closed
Closed
Closed
Closed
justbuchanan added a commit to justbuchanan/kythe that referenced this pull request Mar 29, 2019
@justbuchanan
Initial release (kythe#1)
a7d24e0
@evmar evmar mentioned this pull request Jul 1, 2019
Merged
This was referenced Mar 7, 2025
Merged
Merged
@varunmahajan varunmahajan mentioned this pull request May 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tsl0922 @schroederc