Skip to content

change file permission to 644 #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 8, 2020
Merged

change file permission to 644 #40

merged 1 commit into from
May 8, 2020

Conversation

Enoooch
Copy link
Contributor

@Enoooch Enoooch commented Apr 30, 2020

Issues:
#11
Alamofire:
Alamofire/Alamofire#2527

File system permissions set to -rw-r--r-- which can access images directly, no need to chmod manually.

@kyleduo
Copy link
Owner

kyleduo commented May 8, 2020

I think we can record the origin permissions and set it back to the new file. Using 644 all the time can be arbitrary.

@kyleduo kyleduo merged commit e0e9772 into kyleduo:master May 8, 2020
@Enoooch
Copy link
Contributor Author

Enoooch commented May 8, 2020

I think we can record the origin permissions and set it back to the new file. Using 644 all the time can be arbitrary.

Yes, setting origin permissions is the best solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Enoooch @kyleduo