[Feature] support auto-detect topo for both GPUs and CPUs #244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stmatengss
reviewed
Apr 14, 2025
| @@ -14,21 +14,46 @@ | |||
|
|
|||
| #include "memory_location.h" | |||
|
|
|||
| #ifdef USE_CUDA | |||
There was a problem hiding this comment.
By default, USE_CUDA is off. So we need to set USE_CUDA as ON?
|
almost LGTM, need main merge. |
|
@alogfans It appears there are some conflicts in TransferEngine.init() introduced by the p2phandshade PR. |
doujiang24
reviewed
Apr 16, 2025
doujiang24
added a commit
to doujiang24/Mooncake
that referenced
this pull request
Apr 16, 2025
Signed-off-by: doujiang24 <doujiang24@gmail.com>
ShangmingCai
pushed a commit
that referenced
this pull request
Apr 16, 2025
6 tasks
|
emmm.... what about this case..... |
45 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To enable fully auto detection of topology in Transfer Engine, just leave the device name empty in the Python interface.