Skip to content

🐛In Makefile for add ko-local-build as dependency for installing a local chart #399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 17, 2025
Merged

🐛In Makefile for add ko-local-build as dependency for installing a local chart #399

merged 2 commits into from
Jun 17, 2025

Conversation

Rupam-It
Copy link
Contributor

Summary

Related issue(s)

Fixes #

@Rupam-It
add ko-local-build as depandancy
15ff2e3 
Signed-off-by: Rupam-It <mannarupam3@gmail.com>
@kubestellar-prow kubestellar-prow
Copy link
Contributor

Hi @Rupam-It. Thanks for your PR.

I'm waiting for a kubestellar member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Rupam-It
Copy link
Contributor Author

Rupam-It commented Jun 16, 2025 •
edited
Loading

for
make install-local-chart
previously :

ERROR: image: "ko.local/manager:b0fb8bc" not present locally
make: *** [Makefile:208: kind-load-image] Error 1

now :

Release "kubeflex-operator" has been upgraded. Happy Helming!
NAME: kubeflex-operator
LAST DEPLOYED: Mon Jun 16 21:03:43 2025
NAMESPACE: kubeflex-system
STATUS: deployed
REVISION: 2
TEST SUITE: None
NOTES:

francostellari
francostellari reviewed Jun 16, 2025
View reviewed changes
Makefile Outdated
@@ -204,7 +204,7 @@ ko-local-build:

# this is used for local testing
.PHONY: kind-load-image
kind-load-image:
kind-load-image:ko-local-build
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a SPACE after :

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done!

@Rupam-It
space added
f700f90 
Signed-off-by: Rupam-It <mannarupam3@gmail.com>
@kubestellar-prow kubestellar-prow
Copy link
Contributor

LGTM label has been added.

Git tree hash: 43e7a5b5948bd013a45dba9093bc217dbf1f14ad

@francostellari
Copy link
Contributor

/lgtm

@clubanderson
Copy link
Contributor

/approve

@kubestellar-prow kubestellar-prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clubanderson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow bot merged commit 29436f6 into kubestellar:main Jun 17, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@francostellari francostellari francostellari approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@francostellari francostellari

Labels
approved dco-signoff: yes lgtm needs-ok-to-test size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Rupam-It @francostellari @clubanderson