Ensure context cancellation on command execution failure #1835
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where the deferred
stop()
(fromsignal.NotifyContext
) would not be executed iflogger.L().Fatal(...)
is called due to a command failure. SinceFatal
internally invokesos.Exit(1)
, any deferred functions — includingstop()
— are skipped.To address this, an explicit call to
stop()
is added beforeFatal
to ensure that the context is properly cancelled. This guarantees that any goroutines waiting onctx.Done()
can proceed with cleanup or shutdown logic.Changes
stop()
beforelogger.L().Fatal(...)
inmain
.